Add ignore js flag to format subcommand#1349
Open
andres-lowrie wants to merge 1 commit intodataform-co:mainfrom
Open
Add ignore js flag to format subcommand#1349andres-lowrie wants to merge 1 commit intodataform-co:mainfrom
andres-lowrie wants to merge 1 commit intodataform-co:mainfrom
Conversation
Contributor
Author
|
resurrecting this issue, wondering if I'm the only user who would like this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello
I figured this option may come in handy for users who have different linting/formatting rules for their javascript files but still want to leverage the
sqlxformatter. (Which is the case for us)I took a look at
/tests/sqlx/format.spec.tsand the other files in general to see if there was somewhere I could add tests to but didn't find anything obvious. The file that I'm mentioning seems to specifically test the formatting output and not how the cli calls it. If we need to include tests for this addition, please point me in the right direction and I'll do the needful