Improve error messages when workflow settings have non-string values for default project or dataset

[kolina]

Currently if defautProject or defaultDataset have an integer type in workflow_settings.yaml, a compilation will throw a not very obvious error like t.target.schema.includes is not a function. I've added a validation of these fields to be strings (if not, an explicit error is thrown).

[Ekrekr]

Currently if defautProject or defaultDataset have an integer type in workflow_settings.yaml, a compilation will throw a not very obvious error like t.target.schema.includes is not a function. I've added a validation of these fields to be strings (if not, an explicit error is thrown).

I think there should be a better fix for this:

• workflow_settings.yaml is a version of the workflow settings proto

  dataform/protos/configs.proto

  Line 13 in 05341b7

  message WorkflowSettings {

• We should be catching this during the proto validation

  dataform/common/protos/index.ts

  Line 53 in 05341b7

  if (typeof desiredValue !== typeof presentValue) {

I'm not sure why we're not catching it already - but fixing the proto validation would be the most extensible solution!

[kolina]

• We should be catching this during the proto validation

  dataform/common/protos/index.ts

  Line 53 in 05341b7

  if (typeof desiredValue !== typeof presentValue) {

I also hoped that it should have been the case, but unfortunately this code

dataform/common/protos/index.ts

Lines 45 to 46 in 05341b7

	const proto = protoType.create(object);
	const protoCastObject = protoType.toObject(proto);

doesn't validate types and actually allows to create protoCastObject where defaultDataset has an integer type and this check later doesn't work

dataform/common/protos/index.ts

Line 53 in 05341b7

if (typeof desiredValue !== typeof presentValue) {

The thing that actually verifies types is protoType.verify(). WDYT about using it?

[Ekrekr]

.verify() is a lie, it doesn't actually do anything - there are no situations where the call will actually fail.