Open
Conversation
fernst
requested review from
Ceridan,
kolina and
krushangSk17
and removed request for
a team and
krushangSk17
fernst
force-pushed
the
add-extra-unittest-properties
branch
3 times, most recently
from
ab464b7 to
aa6ac00
Compare
kolina
requested changes
Dec 17, 2025
Comment on lines
+268
to
+276
| Target test_target = 5; | ||
| repeated TestInput inputs = 6; | ||
| string query = 7; | ||
| bool resolve_schema = 8; | ||
|
|
||
| message TestInput { | ||
| Target target = 1; | ||
| string query = 2; | ||
| } |
Contributor
There was a problem hiding this comment.
Sorry, I'm not ready to accept this proposal:
- You're adding a lot of new fields and it'll be super confusing for users to understand the relationship between new
queryandinputsand oldtest_queryandexpected_output_query(I myself spend a lot of time to understand it) - I'm not sure if all of these fields are really needed, I'll need some explanation on how all of these fields are intended to be used and discuss if it's feasible to have more compact compilation output
fernst
force-pushed
the
add-extra-unittest-properties
branch
from
aa6ac00 to
f7b3c5b
Compare
Collaborator
|
Shall we abandon this request in favor of #2063? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds new proto properties to Test entity.
Includes test target + fully resolved reference names for inputs.