Move permissions handling into a QueryHook #254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves permission handling into a new QueryHook implementation called `PermissionsHook` The `AuthManager` is now moved from `HandlerFactory` and `DfSessionService` and is now held only inside the `PermissionsHook` struct. This does not yet move from string processing to query matching, nor do we yet try to completely decouple the permissions logic completely from everything else.
sunng87
approved these changes
Dec 3, 2025
Member
|
@mjgarton This refactoring looks perfect to me. Let me know if you want to update those string matching to statement matching in this patch or next. For me, I think this is already good to merge. The difficult part will be extracting table names from sql statement. I doubt if it's possible at SQL level. I can create a new patch to remove this table-level permission control from auth manager. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves permission handling into a new QueryHook implementation called
PermissionsHookThe
AuthManageris now moved fromHandlerFactoryandDfSessionServiceand is now held only inside thePermissionsHookstruct.This does not yet move from string processing to query matching, nor do we yet try to completely decouple the permissions logic completely from everything else.
Note that did not and still does not have much test coverage, and it's haven't tested it very thoroughly.