Conversation
ThibaudDauce
requested review from
maudetes and
nicolaskempf57
as code owners
ThibaudDauce
force-pushed
the
add_open_graph_link_preview
branch
from
1e29d85 to
e0d78f4
Compare
maudetes
left a comment
maudetes
left a comment
There was a problem hiding this comment.
Let's deploy this on dev and see how it behaves?
| "husky": "^9.1.7", | ||
| "lightningcss": "^1.29.3", | ||
| "lint-staged": "^16.1.2", | ||
| "nuxt-og-image": "6.0.0-beta.34", |
There was a problem hiding this comment.
Should we wait for a stable release?
There was a problem hiding this comment.
Since it's not critical, I'm fine with having a beta release here (and avoid having a PR staying open a long time). But as you wish…
There was a problem hiding this comment.
Depends how you mature you think this is already
There was a problem hiding this comment.
Not really mature (see the two bugs we encounter) but it works and the result is here?
assets/css/fonts.css
Outdated
There was a problem hiding this comment.
What a hell this fonts refactoring 😅 Congrats for sorting this out!
ThibaudDauce
changed the title
| // Workaround: encode the dot before file extension to prevent nuxt-og-image from stripping `.png` in prop values | ||
| // See https://github.com/nuxt-modules/og-image/pull/493 | ||
| defineOgImage('ObjectPage.takumi', { | ||
| objectTitle: dataservice.value?.title, |
There was a problem hiding this comment.
Is there any concern on props sanitization since it is user input?
There was a problem hiding this comment.
I don't think so
3 participants
Close datagouv/data.gouv.fr#1949