-
Notifications
You must be signed in to change notification settings - Fork 4
Fix/recipe duplicates last line of csv apis #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
alexbourret
merged 35 commits into
feature/sniffing-csv-dialect
from
fix/recipe-duplicates-last-line-of-csv-apis
May 18, 2026
Merged
Changes from all commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
aaf4cf9
fixing last line duplication in csv apis via recipe
alexbourret ad19d07
changelog update
alexbourret 3996901
dumping in text mode as last resort
alexbourret 1a4d9fc
beta2
alexbourret 7ecb1c9
adding mTLS
alexbourret 157117b
update recipe for mTLS
alexbourret d5a85bf
upadte connector for mTLS
alexbourret 4d5c579
update changelog
alexbourret af9ff5d
add option overide for csv decoding
alexbourret 34f3125
beta.3
alexbourret 9fe53a8
removing mtls from recipe and connector
alexbourret 3bf56ea
Moving mtls to secure and normal presets
alexbourret 1875efa
adding warnings
alexbourret bd62302
beta.4
alexbourret 4cf3490
update tags and category
alexbourret c5a0c20
removing beta tag
alexbourret 38af12d
storing key+certificats as passwords
alexbourret 6252b88
using temp file for using key+certificats stored in presets
alexbourret 734dd6c
adding mtls keys to data that should not be displayed
alexbourret 987c597
beta.5
alexbourret 5dc9987
removing json assertion, dumping response if json.dumps fails
alexbourret c1e81b0
refacto
alexbourret 7bc0c49
changelog update
alexbourret 581a267
Clarify the UI
alexbourret 1cfed44
Add normalization for RSA keys
alexbourret 59597ce
fix to accept RSA keys
alexbourret b807d85
removing comments
alexbourret 98d8ccd
simplify
alexbourret 185915b
fix get_endpoint_parameters
alexbourret bba5751
UI: moving above the csv parameters names
alexbourret a39cb71
fix log
alexbourret ed6537d
Merge pull request #68 from dataiku/feature/accept-mtls-keys-instead-…
alexbourret e0f799a
Merge pull request #67 from dataiku/feature/move-mtls-settings-to-pre…
alexbourret daaf80f
Merge pull request #66 from dataiku/feature/overide-sniffed-csv-settings
alexbourret 4c19417
Merge pull request #65 from dataiku/feature/add-mtls
alexbourret File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| class DKUConstants(object): | ||
| API_RESPONSE_KEY = "api_response" | ||
| FORBIDDEN_KEYS = ["token", "password", "api_key_value", "secure_token"] | ||
| FORBIDDEN_KEYS = ["token", "password", "api_key_value", "secure_token", "mtls_key_path", "mtls_certificate_path"] | ||
| FORM_DATA_BODY_FORMAT = "FORM_DATA" | ||
| PLUGIN_VERSION = "1.2.7-beta.1" | ||
| PLUGIN_VERSION = "1.2.7-beta.5" | ||
| RAW_BODY_FORMAT = "RAW" | ||
| REPONSE_ERROR_KEY = "dku_error" |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.