Skip to content

Fix/allowing shared subfolders #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexbourret wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix/allowing shared subfolders #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
adcb355
allow subfolders in 'Shared folder name' box
alexbourret Apr 30, 2026
bfa38af
v1.1.3
alexbourret Apr 30, 2026
4a369f4
update changelog
alexbourret Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelog

## [Version 1.1.3](https://github.com/dataiku/dss-plugin-onedrive/releases/tag/v1.1.3) - Bugfix release - 2026-04-30

- Accepts subfolders in shared folders box

## [Version 1.1.2](https://github.com/dataiku/dss-plugin-onedrive/releases/tag/v1.1.2) - Bugfix release - 2025-11-21

- Fix access to shared folders
Expand Down
2 changes: 1 addition & 1 deletion plugin.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"id": "onedrive",
"version": "1.1.2",
"version": "1.1.3",
"meta": {
"label": "OneDrive",
"description": "Read and write data from/to your OneDrive account",
Expand Down
2 changes: 1 addition & 1 deletion python-lib/dss_constants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,4 @@ class DSSConstants(object):
CHILDREN = 'children'
AUTH_OAUTH = "oauth"
AUTH_LOGIN = "login"
PLUGIN_VERSION = "1.1.0"
PLUGIN_VERSION = "1.1.3-beta.1"
3 changes: 2 additions & 1 deletion python-lib/onedrive_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,8 +125,9 @@ def get_item(self, path):
onedrive_item = OneDriveItem(response.json())
return onedrive_item

def get_shared_directory_drive_id(self, shared_directory_name):
def get_shared_directory_drive_id(self, shared_directory_path):
url = self.SHARED_WITH_ME_URL
shared_directory_name = shared_directory_path.split("/")[-1]
while url:
items = self.get(url, headers=self.generate_header())
for item in items.get("value", []):
Expand Down