Skip to content

feat: extract hardcoded proxy ports as named constants #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ykd007 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: extract hardcoded proxy ports as named constants #439

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/backend/config/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,12 @@ import (
"github.com/hannes/kiji-private/src/backend/providers"
)

// DefaultForwardProxyPort is the default port for the forward proxy.
const DefaultForwardProxyPort = ":8080"

// DefaultTransparentProxyPort is the default port for the transparent proxy.
const DefaultTransparentProxyPort = ":8081"

// LoggingConfig holds logging configuration options
type LoggingConfig struct {
LogRequests bool // Log request content
Expand Down Expand Up @@ -242,7 +248,7 @@ func DefaultConfig() *Config {
MistralProviderConfig: defaultMistralProviderConfig,
CustomProviderConfig: defaultCustomProviderConfig,
},
ProxyPort: ":8080",
ProxyPort: DefaultForwardProxyPort,
ONNXModelPath: "",
TokenizerPath: "",
ModelVariant: ModelVariantTrained,
Expand All @@ -261,7 +267,7 @@ func DefaultConfig() *Config {
},
Proxy: ProxyConfig{
TransparentEnabled: true,
ProxyPort: ":8081",
ProxyPort: DefaultTransparentProxyPort,
CAPath: caPath,
KeyPath: keyPath,
EnablePAC: true, // Enable PAC by default for automatic proxy configuration
Expand Down
2 changes: 1 addition & 1 deletion src/backend/server/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,7 @@ func (s *Server) Start() error {
func (s *Server) startTransparentProxy() {
proxyPort := s.config.Proxy.ProxyPort
if proxyPort == "" {
proxyPort = ":8080"
proxyPort = config.DefaultForwardProxyPort
}

log.Printf("Starting transparent proxy on port %s", proxyPort)
Expand Down
Loading