Minor adjustments pre-v2.3#431
Merged
Merged
Conversation
sl-at-ibm
commented
Jun 28, 2026
sl-at-ibm
commented
Collaborator
- (following Cédrick) Different errors if the PCU Group ID is outright nonexistent or belongs to a different cloud provider/region (+ specific tests)
- the error raised is not ValueError anymore, rather DevOpsAPIException
- more robust unmarshaling of pcu-related devops api responses (= everything that is not critical is made optional, no errors if fields missing from responses)
as makes sense; changed the exception raised for non-existing pcu group id in create_database.
erichare
reviewed
Jun 28, 2026
| ) | ||
| else: | ||
| # is the matching group in the right cloud provider / region? | ||
| expected_cpr = (_definition.cloud_provider, _definition.region) |
Collaborator
There was a problem hiding this comment.
Going back to the whole "aws" vs "AWS" discussion... should this perhaps be a case-insensitive comparison? Or do we want to enforce a strict case sensitive match
erichare
approved these changes
Jun 28, 2026
erichare
left a comment
erichare
left a comment
Collaborator
There was a problem hiding this comment.
LGTM @sl-at-ibm , one small question regarding case sensitivity but looks great otherwise
erichare
reviewed
Jun 28, 2026
| ) | ||
| else: | ||
| # is the matching group in the right cloud provider / region? | ||
| expected_cpr = (_definition.cloud_provider, _definition.region) |
Collaborator
There was a problem hiding this comment.
Same question as up above, basically if this side of the comparison should also be case-normalized as well
Collaborator
Author
There was a problem hiding this comment.
Thanks for spotting those! Fixed.
I will also bundle the bump to 2.3 in this PR and then proceed with releasing. (to lessen the business with getting the CI go green).
Coverage reportfor commit: |
Coverage reportfor commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.