feat: Travis to GitHub Actions CI #521
Conversation
Test Results (JDK 11)2 999 tests 2 953 ✅ 1m 22s ⏱️ Results for commit 1ef249d. ♻️ This comment has been updated with latest results. |
Test Results (JDK 17)2 999 tests 2 953 ✅ 1m 20s ⏱️ Results for commit 1ef249d. ♻️ This comment has been updated with latest results. |
Test Results (JDK 8)2 999 tests 2 953 ✅ 1m 16s ⏱️ Results for commit 1ef249d. ♻️ This comment has been updated with latest results. |
Code Coverage Report📊 Coverage: % |
msmygit
force-pushed
the
feat/move_to_gha
branch
from
3967618 to
b20d824
Compare
Code Coverage Report📊 Coverage: % |
Integration Test Results (Cassandra 3.11)3 182 tests 3 136 ✅ 2m 2s ⏱️ Results for commit 1ef249d. ♻️ This comment has been updated with latest results. |
Integration Test Results (Cassandra 4.0)3 182 tests 3 136 ✅ 2m 5s ⏱️ Results for commit 1ef249d. ♻️ This comment has been updated with latest results. |
Integration Test Results (DSE 5.1.48)3 182 tests 3 136 ✅ 1m 48s ⏱️ Results for commit 1ef249d. ♻️ This comment has been updated with latest results. |
Integration Test Results (Cassandra 4.1)3 182 tests 3 136 ✅ 1m 48s ⏱️ Results for commit 1ef249d. ♻️ This comment has been updated with latest results. |
Integration Test Results (Cassandra 5.0)3 182 tests 3 136 ✅ 1m 48s ⏱️ Results for commit 1ef249d. ♻️ This comment has been updated with latest results. |
Integration Test Results (DSE 6.9.17)3 182 tests 3 136 ✅ 2m 3s ⏱️ Results for commit 1ef249d. ♻️ This comment has been updated with latest results. |
Code Coverage Report📊 Coverage: % |
Integration Test Results (DSE 6.8.61)3 182 tests 3 136 ✅ 2m 0s ⏱️ Results for commit 1ef249d. ♻️ This comment has been updated with latest results. |
Code Coverage Report📊 Coverage: % |
Code Coverage Report📊 Coverage: % |
msmygit
force-pushed
the
feat/move_to_gha
branch
from
53d0b02 to
3be9b28
Compare
Code Coverage Report📊 Coverage: % |
msmygit
force-pushed
the
feat/move_to_gha
branch
from
3be9b28 to
0d9d941
Compare
msmygit
force-pushed
the
feat/move_to_gha
branch
from
0d9d941 to
d64b547
Compare
Code Coverage Report📊 Coverage: % |
Code Coverage Report📊 Coverage: % |
Code Coverage Report📊 Coverage: 0% |
Update jacoco to 0.8.8;mockito to 4.11.0 fix with jdk17 runtime
msmygit
force-pushed
the
feat/move_to_gha
branch
from
b8a96a9 to
e47ec73
Compare
Code Coverage Report📊 Coverage: 0% |
Code Coverage Report📊 Coverage: 0% |
msmygit
force-pushed
the
feat/move_to_gha
branch
from
b1b6c65 to
1e7a71b
Compare
Code Coverage Report📊 Coverage: 0% |
Code Coverage Report📊 Coverage: 0% |
| } | ||
|
|
||
| private static String getNodeInfo(Node h) { | ||
| SocketAddress socketAddress = h.getEndPoint().resolve(); |
There was a problem hiding this comment.
Tip
Code reviewers assist 💡 - JDK 8 & 11 has no problems. This is to address the variations across JDK handling of unresolved host address and to prevent errors such as what is observed here with JDK 17, https://github.com/datastax/dsbulk/actions/runs/20583845067/job/59116754575#step:8:1713
There was a problem hiding this comment.
Pull request overview
This PR migrates the project's CI infrastructure from Travis CI and Jenkins to GitHub Actions, modernizing the build and test workflows while maintaining comprehensive testing coverage across multiple Cassandra and DSE versions.
Key Changes:
- Replaced Travis CI, Jenkins, and AppVeyor configurations with GitHub Actions workflows
- Implemented Docker-based testing approach instead of CCM for improved reliability
- Updated test assertions and mocking patterns to support JDK 17 compatibility
- Upgraded build tools (Mockito 4.11.0, JaCoCo 0.8.8) for better JDK support
Reviewed changes
Copilot reviewed 20 out of 21 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/build.yml |
Main build workflow with multi-JDK testing (8, 11, 17) |
.github/workflows/integration-tests.yml |
Integration tests against Cassandra 3.11-5.0 and DSE versions |
.github/workflows/release.yml |
Release automation with artifact generation and GitHub Release creation |
.github/workflows/nightly.yml |
Scheduled nightly builds with full matrix testing |
.github/workflows/code-quality.yml |
Code coverage, style checks, and dependency analysis |
.github/workflows/README.md |
Comprehensive documentation for new workflows |
.github/dependabot.yml |
Automated dependency updates for GitHub Actions |
url/src/main/java/.../S3URLStreamHandler.java |
Enhanced S3 connection with JDK 17 compatibility fixes |
url/src/test/java/.../S3URLStreamHandlerTest.java |
Refactored tests to avoid Mockito spy issues with JDK 17 |
tests/src/main/java/.../DriverUtils.java |
Changed to resolved InetSocketAddress for consistency |
workflow/commons/.../ClusterInformationUtils.java |
Improved node address formatting for better cross-JDK compatibility |
pom.xml |
Updated Mockito and JaCoCo versions, removed optimize flag |
connectors/csv/.../CSVConnectorTest.java |
Updated error message assertion for newer library version |
.travis.yml, Jenkinsfile, appveyor.yml, etc. |
Removed legacy CI configurations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
url/src/main/java/com/datastax/oss/dsbulk/url/S3URLStreamHandler.java
Outdated
Show resolved
Hide resolved
url/src/test/java/com/datastax/oss/dsbulk/url/S3URLStreamHandlerTest.java
Outdated
Show resolved
Hide resolved
tests/src/main/java/com/datastax/oss/dsbulk/tests/driver/DriverUtils.java
Outdated
Show resolved
Hide resolved
| continue-on-error: true | ||
|
|
||
| - name: Upload coverage to Codecov | ||
| uses: codecov/codecov-action@v4 |
There was a problem hiding this comment.
The codecov action is configured with continue-on-error: true and fail_ci_if_error: false, which means failures are silently ignored. While this prevents blocking builds, it reduces visibility into coverage upload issues. Consider logging a warning or creating a job summary when upload fails.
There was a problem hiding this comment.
we still need some work here before fully leveraging this.
msmygit
changed the title
Code Coverage Report📊 Coverage: 0% |
msmygit
force-pushed
the
feat/move_to_gha
branch
from
c5aa1d0 to
1f69140
Compare
Code Coverage Report📊 Coverage: 0% |
Done @absurdfarce 👍🏼 |
Code Coverage Report📊 Coverage: 0% |
No description provided.