Skip to content

Record index build time in buildInMemory path#667

Open
r-devulap wants to merge 1 commit into
mainfrom
build-time-fp-index
Open

Record index build time in buildInMemory path#667
r-devulap wants to merge 1 commit into
mainfrom
build-time-fp-index

Conversation

@r-devulap
Copy link
Copy Markdown
Contributor

buildInMemory (the no-build-compressor path) never recorded the index build time into indexBuildTimes, so getIndexBuildTimeSeconds() always returned null for it. This caused construction.index_build_time_s to be omitted from benchmark results, triggering a warning whenever the metric was selected in the logging config:

WARNING: selected logging output not available; skipping metrics.construction.index_build_time_s (construction.index_build_time_s)

Fix: capture the duration of builder.build() in buildInMemory and store it in indexBuildTimes, consistent with how buildOnDisk already does it. Write time is intentionally excluded — only graph construction is measured.

Before:

Index build time: null seconds

After:

Index build time: 32.192336 seconds

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 20, 2026

Before you submit for review:

  • Does your PR follow guidelines from CONTRIBUTIONS.md?
  • Did you summarize what this PR does clearly and concisely?
  • Did you include performance data for changes which may be performance impacting?
  • Did you include useful docs for any user-facing changes or features?
  • Did you include useful javadocs for developer oriented changes, explaining new concepts or key changes?
  • Did you trigger and review regression testing results against the base branch via Run Bench Main?
  • Did you adhere to the code formatting guidelines (TBD)
  • Did you group your changes for easy review, providing meaningful descriptions for each commit?
  • Did you ensure that all files contain the correct copyright header?

If you did not complete any of these, then please explain below.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant