feat: add /scale subresource to WorkloadDeployment - #201
Open
savme wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the
WorkloadDeploymentscale foundation needed for load-driven autoscaling.Summary
This exposes the standard Kubernetes
/scalesubresource forWorkloadDeployment. HPA and other scalers can use it to write the desired replica count atspec.replicas, read the current count fromstatus.replicas, and discover backing Pods throughstatus.selector.The selector uses the workload deployment UID label:
compute.datumapis.com/workload-deployment-uid=<workloaddeployment uid>The reconciler now initializes/backfills
spec.replicasfromscaleSettings.minReplicasand uses that scale-backed value when deciding how many Instance objects to create.Notes
This PR does not create HPA objects, add metrics, or implement autoscaling policy.
Depends on datum-cloud/unikraft-provider#93
Related to datum-cloud/enhancements#799