chore: use fork of multicluster-runtime for coordinator fix - #320
Open
scotwells wants to merge 1 commit into
Open
chore: use fork of multicluster-runtime for coordinator fix#320scotwells wants to merge 1 commit into
scotwells wants to merge 1 commit into
Conversation
sigs.k8s.io/multicluster-runtime's Coordinator does not gate Manager.GetCluster or reconcile dispatch by cluster ownership, so a replica can act on a project's resources it was never granted ownership of by the sharded coordinator. This is the root cause of issue #319. Point at datum-cloud/multicluster-runtime@fix/coordinator-ownership-gate, which adds Coordinator.Owns(), gates GetCluster on it, and skips reconcile dispatch for non-owned clusters, until the fix is accepted upstream. No application code changes are needed: both mechanisms are enabled by default. Refs #319
scotwells
marked this pull request as ready for review
July 24, 2026 17:33
JoseSzycho
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Interim fix for #319:
sigs.k8s.io/multicluster-runtime'sCoordinatordoesn't gateManager.GetClusteror reconcile dispatch by cluster ownership, so a replica can act on a project's resources it was never granted ownership of by the sharded coordinator, even with a correctly-held fence Lease. This was reproduced directly against a real environment (real Milo control plane, real per-project storage isolation, 3 sharded replicas): with a project's fence Lease held by exactly one replica, all three replicas still reconciled the same object.The fix belongs in the upstream library. We've implemented and validated it in a fork (
datum-cloud/multicluster-runtime, branchfix/coordinator-ownership-gate): addsCoordinator.Owns(), gatesManager.GetClusteron it, and skips reconcile dispatch for non-owned clusters. Both mechanisms are enabled by default, so this is a pure dependency swap — no application code changes.This PR points
go.modat that fork via areplacedirective as an interim measure until the fix is proposed and accepted upstream, at which point this should be reverted in favor of a normal version bump.Test plan
go build ./...andgo mod tidysucceed (verified locally)make testpasses