[SEC-7055] Add imagePullPolicy support for initContainers#259
Open
[SEC-7055] Add imagePullPolicy support for initContainers#259
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds configurable imagePullPolicy support for initContainers in the common and job Helm charts. InitContainers now inherit the main container's image.pullPolicy setting, following the existing pattern used by the cloudsqlProxy sidecar container.
Key Changes:
- Added
imagePullPolicy: {{ .Values.image.pullPolicy }}to all initContainer definitions - Incremented chart versions for both
commonandjobcharts
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| charts/job/templates/job.yaml | Added imagePullPolicy to initContainer configuration |
| charts/job/templates/cronjob.yaml | Added imagePullPolicy to initContainer configuration |
| charts/job/Chart.yaml | Bumped chart version from 0.2.2-beta.0 to 0.2.2-beta.1 |
| charts/common/templates/deployment.yaml | Added imagePullPolicy to initContainer configuration |
| charts/common/templates/deployment-canary.yaml | Added imagePullPolicy to initContainer configuration |
| charts/common/Chart.yaml | Bumped chart version from 0.10.9-beta.1 to 0.10.9-beta.2 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
SEC-7055
Ticket and brief summary
Add configurable
imagePullPolicysupport for initContainers in thecommonandjobcharts. InitContainers now inherit the main container'simage.pullPolicysetting (defaults toAlways), following the existing pattern used by the cloudsqlProxy sidecar container.How did you test your code?
Alwaysby default (matching current behavior)How will you confirm this change is working once it's deployed?
imagePullPolicy: Alwayson initContainersimage.pullPolicyvalues are correctly inherited by initContainers