Skip to content

Fix debugger crashes caused by non-UTF-8 characters#278

Open
huanzai wants to merge 5 commits into
daveleroy:masterfrom
huanzai:pr
Open

Fix debugger crashes caused by non-UTF-8 characters#278
huanzai wants to merge 5 commits into
daveleroy:masterfrom
huanzai:pr

Conversation

@huanzai

@huanzai huanzai commented Nov 27, 2024

Copy link
Copy Markdown

No description provided.

@daveleroy

Copy link
Copy Markdown
Owner

This seems like an adapter issue and not something we should be dealing with on our side. Which adapter are you using and what are you doing that causes it to send non utf-8 characters?

@huanzai

huanzai commented Nov 27, 2024

Copy link
Copy Markdown
Author

I working on a new Lua adapter which works fine on vscode

@daveleroy

daveleroy commented Nov 28, 2024

Copy link
Copy Markdown
Owner

I'm not sure why we would try to work around this on our side and not fix the adapter? Is the adapter actually sending utf8 or is it sending stuff in the wrong encoding?

@huanzai

huanzai commented Nov 28, 2024

Copy link
Copy Markdown
Author

Yes, in Lua adpater something will send non-utf8 characters. I thought SublimeDebugger may not support non-utf8 but it shouldn't raise a error.

@daveleroy

Copy link
Copy Markdown
Owner

SublimeDebugger may not support non-utf8 but it shouldn't raise a error.

The debug adapter protocol explicitly requires utf8 encoded content. If your adapter followed the protocol you wouldn't be getting an error.

See https://microsoft.github.io/debug-adapter-protocol/overview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants