feat: adding TwoEventsWashover base class and was modified validate c…

[Manhe-dev]

base class and was modified validate columns

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 15.38462% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.71%. Comparing base (414133a) to head (c45c6c6).
⚠️ Report is 51 commits behind head on main.

Files with missing lines	Patch %	Lines
cluster_experiments/washover.py	15.38%	22 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #167      +/-   ##
==========================================
- Coverage   97.00%   94.71%   -2.29%     
==========================================
  Files           9        9              
  Lines         902      928      +26     
==========================================
+ Hits          875      879       +4     
- Misses         27       49      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[david26694]

Doing an (unsolicited) review, since I saw you started working on it and I'm going on holidays 🏖️

[david26694]

I'd try to maintain the signature of the abstract washover class, if not it's very hard to put it into power analysis:

    @abstractmethod
    def washover(
        self,
        df: pd.DataFrame,
        truncated_time_col: str,
        treatment_col: str,
        cluster_cols: List[str],
        original_time_col: Optional[str] = None,
    ) -> pd.DataFrame:
        """Abstract method to add washvover to the dataframe."""

[david26694]

For this reason, I'd send start and end columns to the init method

[david26694]

I'd try to avoid do to init with a calendar df, we've tried to keep constructors only based on very simple types like str, int and float. I'd assume the user already has the calendar in the record df, so you don't need to do a join, and it works like other washover classes

[Manhe-dev]

okis, fixing in the next commit.