Skip to content

Check URI is relative before processing as relative #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nickbreese wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Check URI is relative before processing as relative #154

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/Bedrock.Framework.Experimental/Protocols/Http1RequestMessageReader.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,16 @@ public bool TryParseMessage(in ReadOnlySequence<byte> input, ref SequencePositio
return false;
}

//First char must be / for relative URI
if (path[0] == (byte)'/')
Copy link

@smeddows smeddows Jan 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is old. But @adamradocz , won't the compiler just have this as a literal? No need to cache something that isn't an instance, right?

Copy link

@smeddows smeddows Jan 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, @nickbreese, couldn't a relative URIL start with a .? So, like "./Blah"? Or, it could even be "images/image1.jpg"? If any of these are true, this will not work.

Copy link
Contributor

@adamradocz adamradocz Jan 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smeddows, yes, you're right.

Copy link

@smeddows smeddows Jan 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smeddows, yes, you're right.

Which part? :)

{
_httpRequestMessage.RequestUri = new Uri(Encoding.ASCII.GetString(path), UriKind.Relative);
}
else
{
_httpRequestMessage.RequestUri = new Uri(Encoding.ASCII.GetString(path));
}
_httpRequestMessage.Method = new HttpMethod(Encoding.ASCII.GetString(method));
_httpRequestMessage.RequestUri = new Uri(Encoding.ASCII.GetString(path), UriKind.Relative);
_httpRequestMessage.Version = new Version(1, 1);
// Version = Encoding.ASCII.GetString(version.IsSingleSegment ? version.FirstSpan : version.ToArray());

Expand Down