forked from KelvinTegelaar/CIPP-API
-
Notifications
You must be signed in to change notification settings - Fork 0
[pull] dev from KelvinTegelaar:dev #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pull
wants to merge
8,406
commits into
dawsobr2:dev
Choose a base branch
from
KelvinTegelaar:dev
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dawsobr2
pushed a commit
that referenced
this pull request
Feb 26, 2024
[pull] master from KelvinTegelaar:master
Dev to release
Expanded the cippUser schema to include jitAdminStartDate and jitAdminCreatedBy properties. Added caching and loading of function permissions from JSON in Get-CIPPHttpFunctions and Invoke-ListFunctionParameters for improved performance and consistency. Refactored Set-CIPPUserJITAdmin to correctly set schema properties and extract CreatedBy from headers.
Replaces Write-AlertMessage with Write-LogMessage for better error reporting, including severity, API context, and detailed exception data.
Adds -ErrorAction SilentlyContinue and -Compress to ConvertTo-Json and ConvertFrom-Json calls for repository permissions. This change prevents errors from interrupting execution if JSON conversion fails and ensures more robust handling of permission data.
Added null-coalescing operators to ensure $Users and $ServicePrincipals are always arrays, preventing potential errors when responses or cached data are missing or null. Also added -ErrorAction SilentlyContinue to ConvertFrom-Json calls for more robust error handling.
Updated the logic to check for cached GitHub release notes to match the current major.minor version series using semantic versioning, instead of only matching the full release tag. This ensures that release notes are refreshed only when the major.minor version changes, improving cache efficiency.
Refactored location processing in New-CIPPCATemplate to reduce redundant API calls and ensure unique location info. Enhanced Set-CIPPCAPolicyServiceException with clearer logic, improved string handling, and added more informative logging. Minor bug fixes and code style improvements in Invoke-ExecCAServiceExclusion and New-CIPPCAPolicy for robustness.
Dev to hotfix
Updated the error handling in Get-CIPPAlertTERRL.ps1 to use Write-LogMessage instead of Write-AlertMessage, adding more detailed logging with severity, API, and exception data.
Added Get-CIPPMFAStateReport.ps1 to retrieve MFA state from the reporting database and updated Invoke-ListMFAUsers.ps1 to support a UseReportDB query parameter. Improved Get-CIPPMFAState.ps1 to resolve Conditional Access policies with group membership and exclusions, providing more accurate per-user policy coverage. Set-CIPPDBCacheMFAState.ps1 now logs the number of cached MFA state records.
Changed the defaultVersion in host.json and updated version_latest.txt to reflect the new version 10.0.0, replacing 8.8.2.
Dev to release - CIPP X(10.0.0)
Updated all Write-LogMessage calls in public CIPPCore module scripts to use severity 'Debug' instead of 'Info' for standard operation messages. This reduces log verbosity for routine cache and add operations, reserving 'Info' for more significant events.
Updated the Push-BECRun function to filter out entries in MFADevices where '@odata.type' equals '#microsoft.graph.passwordAuthenticationMethod'. This ensures only relevant MFA devices are included in the output.
Bump the defaultVersion in host.json and update version_latest.txt to 10.0.1 to reflect the latest release.
Dev to hotfix
Feat: Add auto enable archive mailbox standard
Added null protection to ListMFAUsers.ps1 supporting fallback when calling non P1 tenants
Updated Get-CIPPMFAStateReport and Get-CIPPMailboxPermissionReport to filter tenants based on the defaultDomainName property from Get-Tenants with -IncludeErrors. This ensures only valid tenants are processed in the reports.
Alert Secure Score
Updated Invoke-ExecCloneTemplate to set Package and SHA to null only if they exist in the template object, preventing unnecessary property assignments.
Refines the filter logic to use an exact match for the count row when the Type parameter is specified, and applies server-side filtering for count rows when Type is not specified. This change improves efficiency by reducing unnecessary client-side filtering.
Introduces Push-GetCalendarPermissionsBatch.ps1 to process calendar permissions in batches. Updates Push-StoreMailboxPermissions.ps1 to aggregate and store calendar permissions alongside mailbox and recipient permissions. Modifies Set-CIPPDBCacheMailboxes.ps1 to create and orchestrate both mailbox and calendar permission batches, enabling unified caching and reporting for all permission types.
Push-CIPPDBCacheData.ps1 now builds a dynamic batch of cache collection tasks based on tenant license capabilities, replacing sequential static calls. The orchestration is started with a single batch, improving maintainability and extensibility. Related changes remove the 'Mailboxes' batch from Start-CIPPDBCacheOrchestrator.ps1 and update test run handling in Invoke-ExecTestRun.ps1 to align with the new orchestration approach.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )