Refactor build workflow by extracting scripts #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move large script blocks from build.yml into separate script files: - WiFi access point setup - System boot configuration - Python environment setup - Geckodriver installation - Bash history setup This improves maintainability while preserving the current functionality. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Move heredoc content from bash scripts into static template files: - Extract configuration files from setup_wifi_ap.sh (dhcpcd.conf, dnsmasq.conf, etc.) - Extract bash_history commands to a separate template - Create .github/templates directory to organize these configuration files - Update scripts to use the new templates This improves maintainability and makes configuration files easier to edit. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Changes: - Inline setup_python_env.sh back into build.yml - Inline setup_bash_history.sh back into build.yml - Remove the inlined script files - Add trailing newlines to all template files - Update README to reflect removed scripts This keeps the more complex configuration scripts separate while avoiding over-abstraction for simpler operations. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Added trailing newlines to: - install_geckodriver.sh - setup_boot.sh - setup_wifi_ap.sh 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Remove all remaining trailing whitespace - Reorder setup scripts to run setup_boot.sh after setup_wifi_ap.sh - Add newline at end of file 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Use consistent project naming: "Go Note Go" instead of "GoNoteGo" - Add trailing newline at end of file 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Use consistent project naming: "Go Note Go" instead of "GoNoteGo" - Add trailing newline at end of file 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Use consistent project naming: "Go Note Go" instead of "GoNoteGo" 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Use consistent project naming: "Go Note Go" instead of "GoNoteGo" 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Original Task
Have a look at .github/workflows/build.yml. Some parts of that should be moved into their own file separate from the yml file, preserving the current behavior. First, list which parts make sense to move out. Then, perform the refactor.
🤖 Generated with Claude Code