Skip to content

Conversation

@dblock
Copy link
Owner

@dblock dblock commented Dec 30, 2025

Summary

  • Migrated from inline Danger workflow steps to numbata/danger-pr-comment reusable workflow
  • Added danger-pr-comment gem dependency and configured Ruby version and bundler cache
  • Simplified workflow configuration for better maintainability
  • Added new danger-comment.yml workflow file
  • Removed deprecated --path flag from bundle install in test workflow

Test plan

  • Verify Danger runs successfully on this PR
  • Check that PR comments are posted correctly
  • Confirm changelog and TOC checks still work
  • Verify ruby-head tests pass without bundler path errors

🤖 Generated with Claude Code

dblock and others added 2 commits December 30, 2025 11:46
Migrate from inline Danger workflow steps to numbata/danger-pr-comment reusable workflow for better maintainability and consistency.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@dblock dblock force-pushed the update-danger-workflow branch from 13d286a to a9108a6 Compare December 30, 2025 16:46
dblock and others added 2 commits December 30, 2025 11:48
The --path flag has been removed in newer Bundler versions. The ruby/setup-ruby action handles bundler caching automatically.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@dblock
Copy link
Owner Author

dblock commented Dec 30, 2025

Will fix coveralls in the next PR.

@dblock dblock merged commit df6e2cb into master Dec 30, 2025
18 of 19 checks passed
@dblock dblock deleted the update-danger-workflow branch December 30, 2025 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants