Skip to content

Conversation

@devhawk
Copy link
Collaborator

@devhawk devhawk commented Feb 3, 2026

fixes #271
fixes #276
supersedes #277

Copy link
Member

@kraftp kraftp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Can we also enable the relevant Conductor test (https://github.com/dbos-inc/dbos-conductor/blob/528b6f605434640eda3f7bad7e00c20383aa82b5/tests/test_workflow_management.py#L932) in Java? It tests export/import over the wire at scale.

Copy link
Collaborator Author

@devhawk devhawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Can we also enable the relevant Conductor test (https://github.com/dbos-inc/dbos-conductor/blob/528b6f605434640eda3f7bad7e00c20383aa82b5/tests/test_workflow_management.py#L932) in Java? It tests export/import over the wire at scale.

does this PR have to merge first?

@kraftp
Copy link
Member

kraftp commented Feb 3, 2026

This is great! Can we also enable the relevant Conductor test (https://github.com/dbos-inc/dbos-conductor/blob/528b6f605434640eda3f7bad7e00c20383aa82b5/tests/test_workflow_management.py#L932) in Java? It tests export/import over the wire at scale.

does this PR have to merge first?

We should be able to run that test with a preview version from this PR, then once it passes we can merge this. But I've found that large-amount-of-data Conductor tests effective at catching bugs in this.

@devhawk
Copy link
Collaborator Author

devhawk commented Feb 10, 2026

This is great! Can we also enable the relevant Conductor test (https://github.com/dbos-inc/dbos-conductor/blob/528b6f605434640eda3f7bad7e00c20383aa82b5/tests/test_workflow_management.py#L932) in Java? It tests export/import over the wire at scale.

does this PR have to merge first?

We should be able to run that test with a preview version from this PR, then once it passes we can merge this. But I've found that large-amount-of-data Conductor tests effective at catching bugs in this.

confirmed relevant conductor test [passes[(https://github.com/dbos-inc/dbos-conductor/actions/runs/21880286179)

@devhawk devhawk merged commit 85d5b76 into main Feb 10, 2026
21 checks passed
@devhawk devhawk deleted the devhawk/import-export branch February 10, 2026 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Possible websocket message truncation Workflow Import/Export/Delete

3 participants