-
Notifications
You must be signed in to change notification settings - Fork 12
Workflow Import/Export/Delete #279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
kraftp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Can we also enable the relevant Conductor test (https://github.com/dbos-inc/dbos-conductor/blob/528b6f605434640eda3f7bad7e00c20383aa82b5/tests/test_workflow_management.py#L932) in Java? It tests export/import over the wire at scale.
devhawk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Can we also enable the relevant Conductor test (https://github.com/dbos-inc/dbos-conductor/blob/528b6f605434640eda3f7bad7e00c20383aa82b5/tests/test_workflow_management.py#L932) in Java? It tests export/import over the wire at scale.
does this PR have to merge first?
We should be able to run that test with a preview version from this PR, then once it passes we can merge this. But I've found that large-amount-of-data Conductor tests effective at catching bugs in this. |
This reverts commit e68e6ae.
transact/src/main/java/dev/dbos/transact/conductor/Conductor.java
Outdated
Show resolved
Hide resolved
…awk/import-export
confirmed relevant conductor test [passes[(https://github.com/dbos-inc/dbos-conductor/actions/runs/21880286179) |
fixes #271
fixes #276
supersedes #277