Conversation
kraftp
left a comment
There was a problem hiding this comment.
I notice the name StepFactory is very broad and there's a more specific PostgresStepFactory. Do you envision using this interface for something other than transactional steps?
Not really. I originally was using "TransactionalStepFactory" but then thought that was just too long. |
kraftp
left a comment
There was a problem hiding this comment.
Looks good! My only quibble is the name, it's not obvious what a StepFactory is. One basic alternative might be TransactionFactory, or even TransactionRunner since it's not really a factory as far as I can tell, it doesn't produce classes but rather runs transactional steps.
|
FYI, I converted this back to draft while I work on the class structure |
This PR introduces Step Factories, a special kind of step for database access. Step factory steps execute as a single transaction, committing both step changes and DBOS chceckpoint atomically
This inial step factory PR provides an abstract PostgresStepFactory plus concrete step factories for JDBC, JDBI and JOOQ. A future PR will add declarative support for Spring Boot at a minimum (a @TransactionalStep annotation to complement @Transactional)
fixes #185