Skip to content

fix(adl): promote cached entries on hit so eviction is LRU not FIFO#151

Open
6figpsolseeker wants to merge 1 commit intodcccrypto:mainfrom
6figpsolseeker:fix/adl-cache-lru-promotion
Open

fix(adl): promote cached entries on hit so eviction is LRU not FIFO#151
6figpsolseeker wants to merge 1 commit intodcccrypto:mainfrom
6figpsolseeker:fix/adl-cache-lru-promotion

Conversation

@6figpsolseeker
Copy link
Copy Markdown

Summary

  • The `/adl/:slab` handler used an in-memory cache with capacity-based eviction via `adlCache.keys().next().value`, which deletes the oldest insertion. Cache hits did not reposition the entry, so a hot slab inserted early would be evicted before cold slabs inserted later.
  • Each cache miss is expensive (Solana RPC `fetchSlab` + full account parsing + ranking), so hot keys evicted under capacity pressure caused redundant RPC load and user-visible latency.
  • Adds the same promotion-on-hit pattern already used in `src/routes/oracle-router.ts` (delete + reinsert before returning the cached payload). The eviction logic at the bottom of the handler is unchanged — it now effectively evicts the least-recently-used entry because the Map's iteration order tracks recency.

Test plan

  • `npx tsc --noEmit` — clean
  • Full test suite: 188/189 passing (the 1 failure is a pre-existing `tests/routes/prices.test.ts` issue on `main`, unrelated)

The /adl/:slab handler used an in-memory cache with capacity-based
eviction via `adlCache.keys().next().value`, which deletes the oldest
*insertion*. Cache hits did not reposition the entry, so a hot slab
inserted early would be evicted before cold slabs inserted later.

Each cache miss is expensive (Solana RPC `fetchSlab` plus full account
parsing and ranking), so a hot key getting evicted under capacity
pressure caused redundant RPC load and user-visible latency.

Add the same promotion-on-hit pattern already used in
`src/routes/oracle-router.ts` (delete + reinsert before returning the
cached payload). The eviction logic at the bottom of the handler is
unchanged — it now effectively evicts the least-recently-used entry
because the Map's iteration order tracks recency.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 9, 2026

Warning

Rate limit exceeded

@6figpsolseeker has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 17 minutes and 1 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 17 minutes and 1 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9a8ab9e1-80e3-4876-9535-ff246c37ff0e

📥 Commits

Reviewing files that changed from the base of the PR and between fb94c29 and 5f063f5.

📒 Files selected for processing (1)
  • src/routes/adl.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant