Skip to content

docs: fix funding history limit — spec said 1000, code caps at 500#158

Open
0x-SquidSol wants to merge 1 commit intodcccrypto:mainfrom
0x-SquidSol:docs/openapi-funding-history-limit
Open

docs: fix funding history limit — spec said 1000, code caps at 500#158
0x-SquidSol wants to merge 1 commit intodcccrypto:mainfrom
0x-SquidSol:docs/openapi-funding-history-limit

Conversation

@0x-SquidSol
Copy link
Copy Markdown
Contributor

Summary

  • Issue: /funding/{slab}/history caps results at 500 rows (funding.ts:346, PERC-8178), but the OpenAPI spec documented maximum: 1000. Clients requesting ?limit=800 would silently receive at most 500 results.
  • Fix: Updates spec maximum from 1000 to 500 and description to match.

Test plan

  • vitest run passes (186/186 tests)
  • Verified MAX_ROWS = 500 in funding.ts:346

🤖 Generated with Claude Code

The /funding/{slab}/history endpoint caps results at 500 rows
(funding.ts:346, PERC-8178) but the OpenAPI spec documented max 1000.
Clients requesting limit=800 would silently receive at most 500 results.

Aligns the spec with the actual implementation.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 9, 2026

Warning

Rate limit exceeded

@0x-SquidSol has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 3 minutes and 24 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 3 minutes and 24 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f34a0fa5-52f6-4623-b768-f4970b342ece

📥 Commits

Reviewing files that changed from the base of the PR and between fb94c29 and 6dd11a1.

📒 Files selected for processing (1)
  • openapi.yaml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant