Skip to content

fix: rename SOLANA_RPC_URL to RPC_URL in .env.example#160

Open
0x-SquidSol wants to merge 1 commit intodcccrypto:mainfrom
0x-SquidSol:fix/env-example-rpc-url-name
Open

fix: rename SOLANA_RPC_URL to RPC_URL in .env.example#160
0x-SquidSol wants to merge 1 commit intodcccrypto:mainfrom
0x-SquidSol:fix/env-example-rpc-url-name

Conversation

@0x-SquidSol
Copy link
Copy Markdown
Contributor

@0x-SquidSol 0x-SquidSol commented Apr 9, 2026

Summary

  • Issue: .env.example documented SOLANA_RPC_URL but @percolator/shared reads RPC_URL (in validation.ts, config.ts, networkValidation.ts). SOLANA_RPC_URL is referenced nowhere in code. Operators copying the example file would set the wrong env var — silently falling back to devnet in development, or crashing in production with a confusing "RPC_URL is required" error.
  • Fix: Renames the env var in .env.example to RPC_URL and adds a comment about using a paid RPC for production.

Changes

  • .env.example: SOLANA_RPC_URLRPC_URL with documentation comment

Test plan

  • vitest run passes (186/186 tests)
  • Verified @percolator/shared reads RPC_URL in validation.ts:39, config.ts:24, networkValidation.ts:52

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Updated RPC endpoint configuration variable name to RPC_URL. Added guidance on distinguishing between production and public mainnet endpoint usage.

The .env.example documented SOLANA_RPC_URL but @percolator/shared
reads RPC_URL (validated in validation.ts, used in config.ts and
networkValidation.ts). Operators copying the example file would set
the wrong env var — silently falling back to devnet in development
or crashing in production with a confusing error.

Also adds a comment noting the public mainnet RPC rate-limits
aggressively and is unsuitable for production.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 9, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 86372799-92d9-4857-89c2-e00da08e13b3

📥 Commits

Reviewing files that changed from the base of the PR and between fb94c29 and 878e489.

📒 Files selected for processing (1)
  • .env.example

📝 Walkthrough

Walkthrough

The .env.example file was updated to rename the Solana RPC endpoint environment variable from SOLANA_RPC_URL to RPC_URL. Accompanying comments were added to clarify that the shared library uses RPC_URL and to document guidance for production versus public mainnet endpoint configuration.

Changes

Cohort / File(s) Summary
Environment Configuration
.env.example
Renamed SOLANA_RPC_URL to RPC_URL with added documentation clarifying the variable name expected by the shared library and production vs. public mainnet endpoint usage.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A rabbit hopped through config land,
Where SOLANA_RPC_URL once did stand,
Now RPC_URL shines so bright,
With comments clear, the path is right!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely summarizes the main change: renaming a configuration variable from SOLANA_RPC_URL to RPC_URL in the .env.example file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant