fix: rename SOLANA_RPC_URL to RPC_URL in .env.example#160
fix: rename SOLANA_RPC_URL to RPC_URL in .env.example#1600x-SquidSol wants to merge 1 commit intodcccrypto:mainfrom
Conversation
The .env.example documented SOLANA_RPC_URL but @percolator/shared reads RPC_URL (validated in validation.ts, used in config.ts and networkValidation.ts). Operators copying the example file would set the wrong env var — silently falling back to devnet in development or crashing in production with a confusing error. Also adds a comment noting the public mainnet RPC rate-limits aggressively and is unsuitable for production. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
.env.exampledocumentedSOLANA_RPC_URLbut@percolator/sharedreadsRPC_URL(invalidation.ts,config.ts,networkValidation.ts).SOLANA_RPC_URLis referenced nowhere in code. Operators copying the example file would set the wrong env var — silently falling back to devnet in development, or crashing in production with a confusing"RPC_URL is required"error..env.exampletoRPC_URLand adds a comment about using a paid RPC for production.Changes
.env.example:SOLANA_RPC_URL→RPC_URLwith documentation commentTest plan
vitest runpasses (186/186 tests)@percolator/sharedreadsRPC_URLin validation.ts:39, config.ts:24, networkValidation.ts:52🤖 Generated with Claude Code
Summary by CodeRabbit
RPC_URL. Added guidance on distinguishing between production and public mainnet endpoint usage.