fix: align price validation ceiling in /funding/:slab with /markets#167
fix: align price validation ceiling in /funding/:slab with /markets#1670x-SquidSol wants to merge 1 commit intodcccrypto:mainfrom
Conversation
The /funding/:slab endpoint used MAX_SANE_PRICE_USD = 1,000,000 ($1M) while /markets uses 1,000,000,000 ($1B) for the same last_price field from the same markets_with_stats view. The comment even claimed "same ceiling used in /markets" which was incorrect. An asset priced between $1M and $1B would show a valid lastPrice in /markets but null in /funding/:slab metadata — inconsistent behavior. Aligns to $1B to match /markets. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 14 minutes and 39 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
Summary
/funding/:slabusedMAX_SANE_PRICE_USD = 1,000,000($1M) while/marketsuses1,000,000,000($1B) for the samelast_pricefield from the samemarkets_with_statsview. The comment even claimed "same ceiling used in /markets" which was factually wrong. An asset priced >$1M would show valid in/marketsbutnullin/funding/:slabmetadata.1,000,000,000($1B) to match/markets.Test plan
vitest runpasses (186/186 tests)🤖 Generated with Claude Code