Skip to content

fix(ws): reject tokens with NaN timestamps in verifyWsToken #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
0x-SquidSol wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(ws): reject tokens with NaN timestamps in verifyWsToken #168

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/routes/ws.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,8 @@ function verifyWsToken(token: string, expectedSlab?: string): { isValid: boolean

const [slabAddress, timestampStr, signature] = parts;
const timestamp = parseInt(timestampStr, 10);

if (Number.isNaN(timestamp)) return { isValid: false, slabAddress: null };

// Check timestamp is within last 5 minutes and not in the future (30s clock skew tolerance)
const now = Date.now();
if (now - timestamp > 5 * 60 * 1000 || timestamp > now + 30_000) {
Expand Down
Loading