Skip to content

fix(mobile): pass oracle_mode from tokenMeta to deploy (PERC-8370)#152

Open
dcccrypto wants to merge 1 commit intomainfrom
fix/PERC-8370-oracle-mode-passthrough
Open

fix(mobile): pass oracle_mode from tokenMeta to deploy (PERC-8370)#152
dcccrypto wants to merge 1 commit intomainfrom
fix/PERC-8370-oracle-mode-passthrough

Conversation

@dcccrypto
Copy link
Copy Markdown
Owner

Problem

handleDeploy hardcoded oracle_mode: 'admin' regardless of the resolved tokenMeta value from the server config. Markets with HyperP or Pyth oracles were deployed with the wrong oracle mode.

Fix

Changed line 294 in MarketCreationScreen.tsx:

- oracle_mode: 'admin',
+ oracle_mode: tokenMeta?.oracle_mode ?? 'admin',

Falls back to 'admin' only when tokenMeta is not yet resolved.

Testing

  • Create a market for a token with a known HyperP pool → oracle_mode should be 'hyperp'
  • Create a market for a token with no pool → oracle_mode should fall back to 'admin'

Closes GH#1989 | PERC-8370

Previously, handleDeploy hardcoded oracle_mode: 'admin' regardless of
the tokenMeta.oracle_mode resolved from the server config. This meant
markets with HyperP or Pyth oracles were incorrectly deployed with
admin oracle mode.

Now uses tokenMeta?.oracle_mode ?? 'admin' to pass through the correct
oracle mode, falling back to 'admin' only when tokenMeta is unavailable.

Closes GH#1989
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 4, 2026

Warning

Rate limit exceeded

@dcccrypto has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 10 minutes and 14 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 10 minutes and 14 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9ae92ce5-d03d-4dc1-a7b0-0957747cc105

📥 Commits

Reviewing files that changed from the base of the PR and between df63f05 and 4eb81cb.

📒 Files selected for processing (1)
  • src/screens/MarketCreationScreen.tsx
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/PERC-8370-oracle-mode-passthrough

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant