Skip to content

security(M-8): gate first queue claim against queue_start_slot#256

Open
0x-SquidSol wants to merge 1 commit intodcccrypto:mainfrom
0x-SquidSol:security/M8-first-claim-time-gate
Open

security(M-8): gate first queue claim against queue_start_slot#256
0x-SquidSol wants to merge 1 commit intodcccrypto:mainfrom
0x-SquidSol:security/M8-first-claim-time-gate

Conversation

@0x-SquidSol
Copy link
Copy Markdown

Summary

  • Severity: Medium — first queue claim bypassed epoch time gate
  • Uses queue_start_slot as reference when last_claim_slot == 0
  • Zero new compile errors

🤖 Generated with Claude Code

The first claim (last_claim_slot == 0) bypassed the epoch duration
time check entirely due to the `> 0` condition. A user could queue
and immediately claim the first epoch's tokens in the same slot.

Fix: Use queue_start_slot as the reference for the first claim,
ensuring at least one full epoch_duration elapses before any claim.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 10, 2026

Warning

Rate limit exceeded

@0x-SquidSol has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 17 minutes and 52 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 17 minutes and 52 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a9a72d80-0fc4-4059-968d-a8c712a5c0f7

📥 Commits

Reviewing files that changed from the base of the PR and between 7e28641 and 6341d5a.

📒 Files selected for processing (1)
  • src/percolator.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant