Skip to content

Use inline comments for PR review findings#19

Merged
dceoy merged 25 commits into
mainfrom
fix/inline-pr-review-comments
Jul 7, 2026
Merged

Use inline comments for PR review findings#19
dceoy merged 25 commits into
mainfrom
fix/inline-pr-review-comments

Conversation

@dceoy

@dceoy dceoy commented Jul 7, 2026

Copy link
Copy Markdown
Owner

Summary

  • update /review-pr so anchored findings are submitted as GitHub inline review comments via gh api
  • prefer OpenCode App authentication from Git config for direct gh api review submissions so inline reviews are authored by opencode-agent[bot] when the default App flow is used
  • align the bundled review-pr skill with the same inline-first and App-auth-preferred contract
  • harden review submission guidance for safe JSON payload creation, secure temporary files, 422 anchor retries, stale head SHA handling, and no-loss fallback
  • document the required permissions and authentication behavior for /review-pr

Verification

  • not run; documentation/prompt-only change

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@dceoy dceoy self-assigned this Jul 7, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OpenCode PR Review: 7 inline finding(s), 1 summary-only finding(s).

Summary-only:

  • .opencode/skills/review-pr/SKILL.md — The skill file still describes the old single-markdown-response behavior and prohibits calling gh api, which contradicts the updated command file. Update SKILL.md to align with the new inline-first contract and gh api submission flow.

Comment thread .opencode/commands/review-pr.md Outdated
Comment thread .opencode/commands/review-pr.md Outdated
Comment thread .opencode/commands/review-pr.md Outdated
Comment thread .opencode/commands/review-pr.md Outdated
Comment thread .opencode/commands/review-pr.md Outdated
Comment thread .opencode/commands/review-pr.md
Comment thread README.md Outdated
@opencode-agent

opencode-agent Bot commented Jul 7, 2026

Copy link
Copy Markdown

Submitted OpenCode PR review with 7 inline comment(s) and 1 summary-only finding.

github run

@dceoy dceoy left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the current head.

CI is green, and I did not find additional issues beyond the existing inline review comments. However, the existing github-actions[bot] review still contains valid blocking points for the new /review-pr inline-submission contract, especially:

  • The review-body example still does not show how summary-only findings and fallback reasons are enumerated.
  • The gh api payload construction guidance should be hardened to avoid unsafe JSON construction and predictable temp-file usage.
  • The retry/fallback flow still needs clearer 422-anchor-error handling, stale headRefOid handling, and no-loss conversion of failed inline findings to summary-only fallback.
  • README wording still blurs the difference between a GitHub review body and the top-level fallback when there are no inline anchors.

Please resolve the existing inline threads before merge. No duplicate inline comments added here.

@dceoy dceoy merged commit 2b739d8 into main Jul 7, 2026
7 checks passed
@dceoy dceoy deleted the fix/inline-pr-review-comments branch July 7, 2026 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant