Use inline comments for PR review findings#19
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
OpenCode PR Review: 7 inline finding(s), 1 summary-only finding(s).
Summary-only:
.opencode/skills/review-pr/SKILL.md— The skill file still describes the old single-markdown-response behavior and prohibits callinggh api, which contradicts the updated command file. Update SKILL.md to align with the new inline-first contract andgh apisubmission flow.
|
Submitted OpenCode PR review with 7 inline comment(s) and 1 summary-only finding. |
dceoy
left a comment
There was a problem hiding this comment.
Reviewed the current head.
CI is green, and I did not find additional issues beyond the existing inline review comments. However, the existing github-actions[bot] review still contains valid blocking points for the new /review-pr inline-submission contract, especially:
- The review-body example still does not show how summary-only findings and fallback reasons are enumerated.
- The
gh apipayload construction guidance should be hardened to avoid unsafe JSON construction and predictable temp-file usage. - The retry/fallback flow still needs clearer 422-anchor-error handling, stale
headRefOidhandling, and no-loss conversion of failed inline findings to summary-only fallback. - README wording still blurs the difference between a GitHub review body and the top-level fallback when there are no inline anchors.
Please resolve the existing inline threads before merge. No duplicate inline comments added here.
Summary
/review-prso anchored findings are submitted as GitHub inline review comments viagh apigh apireview submissions so inline reviews are authored byopencode-agent[bot]when the default App flow is usedreview-prskill with the same inline-first and App-auth-preferred contract/review-prVerification