test: parametrize remaining repeated test shapes#88
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
|
Posted a review on PR #88: No noteworthy issues found. All seven review agents (code quality, performance, test coverage, documentation accuracy, security, project guidelines, and behavioral test analysis) reviewed the diff and returned no actionable findings. The review is live at #88 (review). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor remaining repeated test shapes in
tests/test_dataframe.pyandtests/test_mt5.pyto usepytest.mark.parametrize.Changes
copy_rates_from_as_dfandcopy_rates_range_as_dfinto one parametrized test usingclient_method,mt5_method, andcall_kwargs.order_check_as_dfandorder_send_as_dfinto one parametrized test, preserving the request/result column assertions viamocker.MagicMockfor the request/result rows.test_get_methods_with_parametersintomethod_name × kwargscases sogroupandticketare separate cases per method (orders_get,positions_get).Design notes
order_action_as_dfmock uses the samemocker.MagicMockapproach as the existingorder_action_as_dicttest.QA
uv run ruff formatuv run ruff checkuv run pyrightuv run pytest— 324 passed, 33 skipped, 100% coverage./.agents/skills/local-qa/scripts/qa.sh— green