-
Notifications
You must be signed in to change notification settings - Fork 16
BKG 2.0: SD-2733: Add Vessel-Voyage info per leg #599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
HenrikHL
wants to merge
6
commits into
master
Choose a base branch
from
SD-2733_Add-Vessel-Voyage-per-leg
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+63
−7
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
55fbf3d
BKG 2.0: SD-2733: Add Vessel-Voyage info per leg
HenrikHL 8313796
Update flag
HenrikHL 954246a
Fix vesselFlag spectral rule
HenrikHL 25d9d2b
Change ' -> '
HenrikHL df1f0d0
Align on USR description
HenrikHL e2fedc1
Remove VesselFlag and VesselCallSign
HenrikHL File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5091,6 +5091,62 @@ components: | |
|
|
||
| **Note:** Use `ROU` when `routingReference` is used in order to comply with the need to add at least 1 `shipmentLocation` to a Booking request. | ||
| example: PRE | ||
| departingVesselVoyage: | ||
| type: object | ||
| title: Vessel Voyage | ||
| description: | | ||
| Vessel and voyage details of a transport leg. | ||
|
|
||
| **Note:** This property is not to be used in combination with `locationTypeCode='ROU'`. | ||
| properties: | ||
| vesselName: | ||
| type: string | ||
| pattern: ^\S(?:.*\S)?$ | ||
| maxLength: 50 | ||
| description: | | ||
| The name of the Vessel given by the Vessel Operator and registered with IMO. | ||
| example: King of the Seas | ||
| vesselIMONumber: | ||
| type: string | ||
| pattern: ^\d{7,8}$ | ||
| minLength: 7 | ||
| maxLength: 8 | ||
| description: | | ||
| The unique reference for a registered Vessel. The reference is the International Maritime Organisation (IMO) number, also sometimes known as the Lloyd's register code, which does not change during the lifetime of the vessel | ||
| example: '9321483' | ||
| carrierServiceCode: | ||
| type: string | ||
| pattern: ^\S(?:.*\S)?$ | ||
| maxLength: 11 | ||
| description: | | ||
| The carrier-specific code of the service for which the schedule details are published. | ||
| example: FE1 | ||
| universalServiceReference: | ||
| type: string | ||
| pattern: ^SR\d{5}[A-Z]$ | ||
| minLength: 8 | ||
| maxLength: 8 | ||
| description: | | ||
| A global unique service reference, as per DCSA standard, agreed by VSA partners for the service. The service reference must match the regular expression pattern: `SR\d{5}[A-Z]`. The letters `SR` followed by `5 digits`, followed by a checksum-character as a capital letter from `A to Z`. | ||
| example: SR12345A | ||
| carrierExportVoyageNumber: | ||
| type: string | ||
| pattern: ^\S(?:.*\S)?$ | ||
| maxLength: 50 | ||
| description: | | ||
| The identifier of an export voyage. The carrier-specific identifier of the export Voyage. | ||
| example: 2103S | ||
| universalExportVoyageReference: | ||
| type: string | ||
| pattern: ^\d{2}[0-9A-Z]{2}[NEWSR]$ | ||
| minLength: 5 | ||
| maxLength: 5 | ||
| description: | | ||
| A global unique voyage reference for the export Voyage, as per DCSA standard, agreed by VSA partners for the voyage. The voyage reference must match the regular expression pattern: `\d{2}[0-9A-Z]{2}[NEWSR]` | ||
| - `2 digits` for the year | ||
| - `2 alphanumeric characters` for the sequence number of the voyage | ||
| - `1 character` for the direction/haul (`N`orth, `E`ast, `W`est, `S`outh or `R`oundtrip). | ||
| example: 2103N | ||
| required: | ||
| - location | ||
| - locationTypeCode | ||
|
|
@@ -6712,7 +6768,7 @@ components: | |
| minLength: 7 | ||
| maxLength: 8 | ||
| description: | | ||
| The unique reference for a registered Vessel. The reference is the International Maritime Organisation (IMO) number, also sometimes known as the Lloyd's register code, which does not change during the lifetime of the vessel | ||
| The unique reference for a registered Vessel. The reference is the International Maritime Organisation (IMO) number, also sometimes known as the Lloyd's register code, which does not change during the lifetime of the vessel | ||
| example: '9321483' | ||
| carrierServiceCode: | ||
| type: string | ||
|
|
@@ -7114,5 +7170,5 @@ components: | |
| minLength: 7 | ||
| maxLength: 8 | ||
| description: | | ||
| The unique reference for a registered Vessel. The reference is the International Maritime Organisation (IMO) number, also sometimes known as the Lloyd's register code, which does not change during the lifetime of the vessel | ||
| The unique reference for a registered Vessel. The reference is the International Maritime Organisation (IMO) number, also sometimes known as the Lloyd's register code, which does not change during the lifetime of the vessel | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same minor change, (.) at the end as above. To be consistent with other descriptions. |
||
| example: '9321483' | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.