Cosmetic changes / fixes#76
Open
Hecatron wants to merge 6 commits intoddobrev:masterfrom
Hecatron-Forks:devel
Open
Cosmetic changes / fixes#76Hecatron wants to merge 6 commits intoddobrev:masterfrom Hecatron-Forks:devel
Hecatron wants to merge 6 commits intoddobrev:masterfrom
Hecatron-Forks:devel
Conversation
…within QtSharp.CLI
Owner
|
Thank you very much for your work. I'm afraid I am too busy now but I'll look into it over the week-end. |
Collaborator
|
By the way, you can replace CppSharp's logging/diagnostic implementation, see https://github.com/mono/CppSharp/blob/8479ed3735b0e88b9dd816993bf8a0f0028e711f/src/Core/Diagnostics.cs#L41 |
Contributor
Author
|
Thanks for the info, I've now set it up to redirect CppSharp's Diagnostics across to LibLog / Serilog so now it picks up on the different levels of log message for filtering. What I could do is take out the LibLog file I've added to QtSharp |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I've recently added in some changes
These are mostly cosmetic, and based around personal preference so I'll understand if they don't make it in
Let me know what you think.
I've tested on Windows using Visual Studio 2015 / QT 5.9.1
I've not managed to test against mono / linux just yet, currently looking at that at the moment.
Moved a couple of functions into QtInfo since it seems to be a better place for them
also it makes the cli Program look a little less cluttered.
Updated some of the NuGet package references to later versions
(not CppSharp since there's some small API changes there that need to be looked at)
Added in LibLog / SeriLog logging
LibLog is an abstraction layer which is normally used in libraries to Log
The general idea is liblog figures out which logging system is in use and directs the messages to that.
Serilog is a specific implementation of a Logger that's used within the CLI Application
I've added in coloured console / file logging so far, although there's also a full list of sinks here
https://github.com/serilog/serilog/wiki/Provided-Sinks
There's also a wrapper in there to pickup on the Console.WriteLine's from CppSharp and pipe them via Serilog / LibLog
I've got some other ideas as well like docs I'll take another look at, but I figured I'd see if these make it in first.