Fix encoding error on Windows when not outputting to terminal#143
Open
ryanbuck182 wants to merge 8 commits intodduan:mainfrom
Open
Fix encoding error on Windows when not outputting to terminal#143ryanbuck182 wants to merge 8 commits intodduan:mainfrom
ryanbuck182 wants to merge 8 commits intodduan:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #136
On Windows, when piping the command output somewhere else, it would cause an encoding error where the tree lines would be encoded as undesired special characters. The built-in
treecommand on Windows gets around this by automatically switching to an ASCII version of the tree. This PR makes a similar change totre.Now, on Windows, the output of something like
tre | clipwill be something like:Instead of:
This successfully avoids the encoding errors.
Full List of Changes:
src/diagram_formatting.rsCharsetenum for different sets of characters to render the diagram with (currently just Unicode and ASCII)PrefixSegment::as_str()method to return the appropriate string based on theCharsetmake_prefix,format_file, andformat_pathsnow accept aCharsetparameterformatting_workstest to work with new function signaturesformatting_asciiunit test for formatting with ASCIItest_input()helpersrc/tre.rsrunfunction that switches theCharsetif on Windows and not outputting to a TTYtests/integration_tests.rs