Skip to content

feat: parse Street Brawl item draft bucketing#397

Open
Vergir wants to merge 2 commits into
developfrom
feature/street-brawl-item-bucketing
Open

feat: parse Street Brawl item draft bucketing#397
Vergir wants to merge 2 commits into
developfrom
feature/street-brawl-item-bucketing

Conversation

@Vergir

@Vergir Vergir commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator

Parse m_mapItemDraftBucketing and m_mapItemDraftCounterWeights into a heradata.json. This will allow to list items that are more/less likely to be drafted for each hero in Street Brawl.

Parsed data in deadlock-data PR - Reopen deadbot PR or run deploy workflow for this branch here to reparse the data

Parse m_mapItemDraftBucketing and m_mapItemDraftCounterWeights from hero
data into a grouped ItemDraftBucketing field on each hero. Items are
grouped into Good/Normal buckets (with weights) plus a Counter bucket
sourced from counter weights. Buckets are only emitted when non-empty.
@Vergir

Vergir commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator Author

One thing I'm a bit on the fence about is that it our hero_data gets quite bigger: from 200kb to 1.6mb. Lines count from 6k to 52k. CSV is roughtly same. We can move the new data to a separate file, like street_brawl.json, but I'm not sure if it's a good idea, to separate it like this. In the end i chose to stay in hero_data, but open to any corrections here.

@hassayag

Copy link
Copy Markdown
Member

One thing I'm a bit on the fence about is that it our hero_data gets quite bigger: from 200kb to 1.6mb. Lines count from 6k to 52k. CSV is roughtly same. We can move the new data to a separate file, like street_brawl.json, but I'm not sure if it's a good idea, to separate it like this. In the end i chose to stay in hero_data, but open to any corrections here.

Yeah I'd agree it is too large for the hero json file, especially if we think this would be used on a page separate from each hero's main page. Have you seen any patterns in the data that show certain heroes share X set of weights? As I can see that one of the sets is used across 24 heroes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants