Proposed fix to issue #74. Minor code cleanup.#80
Open
dpeschel wants to merge 2 commits intodeadpixi:masterfrom
Open
Proposed fix to issue #74. Minor code cleanup.#80dpeschel wants to merge 2 commits intodeadpixi:masterfrom
dpeschel wants to merge 2 commits intodeadpixi:masterfrom
Conversation
Proposed fix: 1. When you have not typed the command character, and you type any unhandled special key, such as F20 or clear all tabs or help, mtm ignores it. 2. When you have typed the command character, and you type any unhandled key (special or not), mtm cancels the command. 3. Then the BAILOUT key becomes unnecessary because all unknown keys bail out. (So the code and the configuration files should not define it.) And the manual should say explicitly that all unknown keys bail out. Cleanup: Added blank lines, removed extra semicolons, changed comma operator to two separate statements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed fix:
When you have not typed the command character, and you type any unhandled special key, such as F20 or clear all tabs or help, mtm ignores it.
When you have typed the command character, and you type any unhandled key (special or not), mtm cancels the command.
Then the BAILOUT key becomes unnecessary because all unknown keys bail out. (So the code and the configuration files should not define it.) And the manual should say explicitly that all unknown keys bail out.
Cleanup:
Added blank lines, removed extra semicolons, changed comma operator to two separate statements.