This repository was archived by the owner on Feb 5, 2025. It is now read-only.
Fix compiling parameters and dependencies for macOS#121
Open
jacksonbenete wants to merge 4 commits intodeadpixi:masterfrom
Open
Fix compiling parameters and dependencies for macOS#121jacksonbenete wants to merge 4 commits intodeadpixi:masterfrom
jacksonbenete wants to merge 4 commits intodeadpixi:masterfrom
Conversation
detect OS and apply mac configuration requirements
Author
|
I'm detecting Darwin but not BSD though, since I don't have the various versions of BSD to test if the changes are still needed for compilation. |
target mac os x versions before 10.7 release
Author
|
This will also address #120 . On line 18 I've detected the system version: This is a bit cryptic, alternatively we can get more verbose: |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hope you don't mind the pull request.
This will only make it easier for compiling sam on macOS.
People on macOS don't have to change config.mk, as we'll be adding the dependencies automatically.
Do you think this is a good idea?