Skip to content

chore: refactor In-Progress to showcase proposal - #85

Draft
aleortega wants to merge 2 commits into
mainfrom
chore/WKC-presentation
Draft

chore: refactor In-Progress to showcase proposal#85
aleortega wants to merge 2 commits into
mainfrom
chore/WKC-presentation

Conversation

@aleortega

@aleortega aleortega commented Jun 18, 2025

Copy link
Copy Markdown
Contributor

From:
image

To:
image

Criteria followed:
Type of components: ports, adapters, logic, controllers (handlers)
ports: external; database, redis, etc. (external libraries, what we need to mock)
adapters: internal mappings with injected functions/mappings (do not call anything but injected functions)
logic: business logic (calls ports to retrieve data and parse the data calling adapters)
controllers: handlers (only call logic)

@aleortega
aleortega marked this pull request as draft June 18, 2025 10:57
@coveralls

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 15755199786

Details

  • 27 of 30 (90.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 74.632%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/logic/scenes-service.ts 13 14 92.86%
src/controllers/handlers/scene-admin-handlers/list-scene-admins-handler.ts 7 9 77.78%
Totals Coverage Status
Change from base Build 15640312704: 0.06%
Covered Lines: 1037
Relevant Lines: 1321

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants