Skip to content

fix: regenerated missing meta files - #9748

Merged
davidejensen merged 1 commit into
devfrom
fix/regen-missing-meta
Aug 14, 2026
Merged

fix: regenerated missing meta files#9748
davidejensen merged 1 commit into
devfrom
fix/regen-missing-meta

Conversation

@davidejensen

Copy link
Copy Markdown
Member

Pull Request Description

What does this PR change?

We had some missing .meta coming from AI PRs that didn't run unity before committing to dev, this PR jsut generates those missing meta files

@davidejensen davidejensen self-assigned this Aug 14, 2026
@davidejensen
davidejensen requested review from a team as code owners August 14, 2026 10:39
@davidejensen davidejensen added the no QA needed Used to tag pull requests that does not require QA validation label Aug 14, 2026
@davidejensen
davidejensen removed the request for review from a team August 14, 2026 10:39
@github-actions

github-actions Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

🚦 CI Status

Build

New build in progress, come back later!

Lint

No C# files changed — lint ratchet skipped.

Tests

All Unity tests passed ✅

TESTS SUITE Result Passed Failed Skipped
EditMode ✅ Passed 24971 0 13
PlayMode ✅ Passed 236 0 36

@decentraland-bot
decentraland-bot self-requested a review August 14, 2026 10:39

@decentraland-bot decentraland-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Review — fix: regenerated missing meta files

STEP 1 — Context & Scope

The diff adds 11 new Unity .meta files across four areas:

  • AvatarRendering/AvatarShape/Tests/PerformanceTests/ — 1 folder meta + 1 .cs.meta
  • AvatarRendering/AvatarShape/Tests/PlayMode/ — 1 .cs.meta
  • Infrastructure/ECS/Unity/Transforms/Tests/PerformanceTests/ — 1 folder meta + 1 .cs.meta
  • Landscape/Tests/PerformanceTests/GroundContainerReuse/ — 3 folder metas + 1 .cs.meta
  • Tests/PlayMode/PerformanceTests/ — 2 .cs.meta files

All are standard Unity metadata files. No runtime code, no .cs changes, no system/component modifications.

STEP 2 — Root-cause check ✅

The problem: AI-authored PRs committed .cs performance test files to dev without opening the Unity editor, which normally auto-generates the corresponding .meta files. This PR adds those missing .meta files — the correct fix. Not a symptom workaround.

STEP 3 — Design & integration ✅

N/A — no new code units, systems, components, or persistent state. Only Unity asset metadata.

Verification performed:

  • Confirmed all 6 .cs source files exist on the branch (tree search on fix/regen-missing-meta).
  • Confirmed all 11 GUIDs are unique within this diff.
  • Confirmed .cs.meta format (2-line: fileFormatVersion + guid, no trailing newline) matches existing files in the same directories (e.g. AbCdnPerformanceTests.cs.meta).
  • Confirmed folder .meta format uses standard DefaultImporter block — valid Unity format.

STEP 4 — Member audit ✅

N/A — no code members added or changed.

STEP 5 — Line-level review ✅

No issues found. All files follow established repo conventions for Unity .meta files.

Security review: No security concerns — files contain only Unity GUIDs and standard importer settings.

STEP 6 — Complexity

SIMPLE — metadata-only, zero logic changes.

STEP 7 — QA assessment

NO.meta files are Unity editor/build metadata. No user-facing behavior is affected.

STEP 8 — Non-blocking warnings

None.

STEP 9 — Verdict

REVIEW_RESULT: PASS ✅
COMPLEXITY: SIMPLE
COMPLEXITY_REASON: Adds only Unity .meta files for pre-existing performance test scripts — no runtime code changes.
QA_REQUIRED: NO


Reviewed by Jarvis 🤖 · Requested by decentraland-bot via GitHub

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved based on Jarvis review — simple fix/chore with no blocking issues. No QA needed (non-runtime changes only).

@davidejensen
davidejensen enabled auto-merge (squash) August 14, 2026 11:13
@decentraland-bot

Copy link
Copy Markdown
Contributor

PR #9748, run #31795474746

Builds: Windows change, Windows baseline, macOS change, macOS baseline

How to read this table
  • Each build is measured 3 times. The values are the median, and (min–max) is the lowest and highest of those runs — a wide range means the metric is noisy and small differences are not trustworthy.
  • Δ is Change minus Baseline (a negative Δ means Change is faster).
  • 🟢 faster / 🔴 slower — a real difference: larger than both 3% and the run-to-run range.
  • ⚪ within noise — the difference is smaller than how much the build varies between its own runs, so it cannot be told apart from random variation. Treat it as no change.
  • Exceptions per run — the average number of exceptions in a run's log; more than the baseline is flagged 🔴 even when frame times look fine. The Exception breakdown under each table groups them by the explorer's report category and exception type (as totals across the runs).
  • A run that logged unusually many exceptions (at least 10 and 5× the median of its build's runs — e.g. a service was down during it) is excluded from all numbers and called out under the table.

Intel Core i5

Metric Baseline Change Δ Result
Samples 2331 (×3) 2370 (×3)
CPU average 38.3 ms (36.6–38.8) 37.8 ms (37.2–37.9) -0.5 ms ⚪ within noise
CPU 1% worst 380.0 ms (330.7–396.1) 300.9 ms (283.9–304.8) -79.0 ms 🟢 21% faster
CPU 0.1% worst 411.3 ms (351.0–424.5) 314.3 ms (294.7–318.0) -97.0 ms 🟢 24% faster
GPU average 8.0 ms (8.0–8.0) 9.4 ms (9.2–9.6) 1.4 ms 🔴 18% slower
GPU 1% worst 18.8 ms (18.6–19.3) 32.2 ms (29.5–32.9) 13.4 ms 🔴 71% slower
GPU 0.1% worst 19.2 ms (19.0–20.2) 38.1 ms (36.1–39.6) 19.0 ms 🔴 99% slower
Exceptions per run 66 66 0 ⚪ none new
Exception breakdown
Exception Baseline (3 runs) Change (3 runs)
[UI] DllNotFoundException 192 192
[ENGINE] NullReferenceException 3 3
[ENGINE] ObjectDisposedException 3 3

Apple M1

Metric Baseline Change Δ Result
Samples 4066 (×3) 4052 (×3)
CPU average 22.1 ms (21.9–22.1) 22.1 ms (22.0–22.8) 0.0 ms ⚪ within noise
CPU 1% worst 231.3 ms (196.1–233.3) 229.7 ms (228.1–234.2) -1.5 ms ⚪ within noise
CPU 0.1% worst 233.6 ms (231.9–238.3) 236.1 ms (233.9–238.2) 2.5 ms ⚪ within noise
GPU average 2.5 ms (1.9–2.7) 2.6 ms (2.6–2.7) 0.1 ms ⚪ within noise
GPU 1% worst 34.6 ms (34.2–35.5) 35.1 ms (34.4–35.6) 0.6 ms ⚪ within noise
GPU 0.1% worst 35.7 ms (35.2–37.2) 36.6 ms (35.5–37.9) 0.9 ms ⚪ within noise
Exceptions per run 0 0 0 ⚪ none new

@davidejensen davidejensen added force-build Used to trigger a build on draft PR no QA needed Used to tag pull requests that does not require QA validation and removed no QA needed Used to tag pull requests that does not require QA validation force-build Used to trigger a build on draft PR labels Aug 14, 2026
@davidejensen
davidejensen merged commit cfec223 into dev Aug 14, 2026
88 of 107 checks passed
@davidejensen
davidejensen deleted the fix/regen-missing-meta branch August 14, 2026 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

claude-approved no QA needed Used to tag pull requests that does not require QA validation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants