fix: regenerated missing meta files - #9748
Conversation
decentraland-bot
left a comment
There was a problem hiding this comment.
PR Review — fix: regenerated missing meta files
STEP 1 — Context & Scope
The diff adds 11 new Unity .meta files across four areas:
AvatarRendering/AvatarShape/Tests/PerformanceTests/— 1 folder meta + 1.cs.metaAvatarRendering/AvatarShape/Tests/PlayMode/— 1.cs.metaInfrastructure/ECS/Unity/Transforms/Tests/PerformanceTests/— 1 folder meta + 1.cs.metaLandscape/Tests/PerformanceTests/GroundContainerReuse/— 3 folder metas + 1.cs.metaTests/PlayMode/PerformanceTests/— 2.cs.metafiles
All are standard Unity metadata files. No runtime code, no .cs changes, no system/component modifications.
STEP 2 — Root-cause check ✅
The problem: AI-authored PRs committed .cs performance test files to dev without opening the Unity editor, which normally auto-generates the corresponding .meta files. This PR adds those missing .meta files — the correct fix. Not a symptom workaround.
STEP 3 — Design & integration ✅
N/A — no new code units, systems, components, or persistent state. Only Unity asset metadata.
Verification performed:
- Confirmed all 6
.cssource files exist on the branch (tree search onfix/regen-missing-meta). - Confirmed all 11 GUIDs are unique within this diff.
- Confirmed
.cs.metaformat (2-line:fileFormatVersion+guid, no trailing newline) matches existing files in the same directories (e.g.AbCdnPerformanceTests.cs.meta). - Confirmed folder
.metaformat uses standardDefaultImporterblock — valid Unity format.
STEP 4 — Member audit ✅
N/A — no code members added or changed.
STEP 5 — Line-level review ✅
No issues found. All files follow established repo conventions for Unity .meta files.
Security review: No security concerns — files contain only Unity GUIDs and standard importer settings.
STEP 6 — Complexity
SIMPLE — metadata-only, zero logic changes.
STEP 7 — QA assessment
NO — .meta files are Unity editor/build metadata. No user-facing behavior is affected.
STEP 8 — Non-blocking warnings
None.
STEP 9 — Verdict
REVIEW_RESULT: PASS ✅
COMPLEXITY: SIMPLE
COMPLEXITY_REASON: Adds only Unity .meta files for pre-existing performance test scripts — no runtime code changes.
QA_REQUIRED: NO
Reviewed by Jarvis 🤖 · Requested by decentraland-bot via GitHub
|
PR #9748, run #31795474746 Builds: Windows change, Windows baseline, macOS change, macOS baseline How to read this table
Intel Core i5
Exception breakdown
Apple M1
|
Pull Request Description
What does this PR change?
We had some missing .meta coming from AI PRs that didn't run unity before committing to dev, this PR jsut generates those missing meta files