fix: address consensus review feedback #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

qj0r9j0vc2 wants to merge 1 commit into heiji/malachite-integration from qj0r9j0vc2/malachite-integration

Member

qj0r9j0vc2 commented Jan 11, 2026

This PR addresses feedback from the initial consensus module review.

Key improvements:

Added comprehensive error handling with ConsensusError enum
Fixed empty validator set validation in CipherBftContext
Corrected CutProposalPart equality to include first/last flags
Wired consensus config timeouts through to engine
Added 15 unit tests for all key components

All tests passing.


          fix: address PR review feedback

3f4d4fd

qj0r9j0vc2 marked this pull request as ready for review

January 11, 2026 12:07

qj0r9j0vc2 requested a review from heijiLee

January 11, 2026 12:07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet