fix(vm): prevent over-creation of vmmac on additional interface updates#2184
Open
LopatinDmitr wants to merge 1 commit intomainfrom
Open
fix(vm): prevent over-creation of vmmac on additional interface updates#2184LopatinDmitr wants to merge 1 commit intomainfrom
LopatinDmitr wants to merge 1 commit intomainfrom
Conversation
danilrwx
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix two issues in VM additional network handling:
VirtualMachineMACAddressresources when adding additional interfaces.The MAC handler now creates only the missing amount of VMMAC resources.
EnsureNetworkInterfaceIDsnow pre-collects all already assigned positive IDs before allocating missing ones, so generated IDs do not collide with IDs that appear later in the network list.Regression tests were added for both cases.
Why do we need it, and what problem does it solve?
Two bugs were observed during additional interface updates:
2-3) VMMAC/VMMACL resources instead of exactly one.spec.networks, leading to unstable or conflicting IDs.This patch makes both resource creation and ID allocation deterministic.
What is the expected result?
Checklist
Changelog entries