fix openrouter binding #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🚀 Preview Deployments Ready!Your changes have been deployed to preview environments: 📦
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
2 issues found across 1 file
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="openrouter/server/tools/llm-binding.ts">
<violation number="1" location="openrouter/server/tools/llm-binding.ts:480">
P1: Empty input schema removes validation for required properties (`modelId`, `callOptions`) that the execute function depends on. This will cause runtime errors when these properties are missing from the context. Consider defining a proper schema that includes the required fields, or using the original `STREAM_BINDING.inputSchema`.</violation>
<violation number="2" location="openrouter/server/tools/llm-binding.ts:515">
P2: Empty output schema removes validation and creates a type mismatch with the return statement which casts to `GENERATE_BINDING.outputSchema`. The actual runtime output won't be validated against any schema.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| outputSchema: GENERATE_BINDING.outputSchema, | ||
| // inputSchema: GENERATE_BINDING.inputSchema, | ||
| inputSchema: z.object({}), | ||
| outputSchema: z.object({}), |
There was a problem hiding this comment.
P2: Empty output schema removes validation and creates a type mismatch with the return statement which casts to GENERATE_BINDING.outputSchema. The actual runtime output won't be validated against any schema.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At openrouter/server/tools/llm-binding.ts, line 515:
<comment>Empty output schema removes validation and creates a type mismatch with the return statement which casts to `GENERATE_BINDING.outputSchema`. The actual runtime output won't be validated against any schema.</comment>
<file context>
@@ -509,8 +510,9 @@ export const createLLMGenerateTool = (env: Env) =>
- outputSchema: GENERATE_BINDING.outputSchema,
+ // inputSchema: GENERATE_BINDING.inputSchema,
+ inputSchema: z.object({}),
+ outputSchema: z.object({}),
execute: async ({ context }) => {
const {
</file context>
Suggested change
| outputSchema: z.object({}), | |
| outputSchema: GENERATE_BINDING.outputSchema, |
| "Returns a streaming response for interactive chat experiences.", | ||
| inputSchema: STREAM_BINDING.inputSchema, | ||
| // inputSchema: STREAM_BINDING.inputSchema, | ||
| inputSchema: z.object({}), |
There was a problem hiding this comment.
P1: Empty input schema removes validation for required properties (modelId, callOptions) that the execute function depends on. This will cause runtime errors when these properties are missing from the context. Consider defining a proper schema that includes the required fields, or using the original STREAM_BINDING.inputSchema.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At openrouter/server/tools/llm-binding.ts, line 480:
<comment>Empty input schema removes validation for required properties (`modelId`, `callOptions`) that the execute function depends on. This will cause runtime errors when these properties are missing from the context. Consider defining a proper schema that includes the required fields, or using the original `STREAM_BINDING.inputSchema`.</comment>
<file context>
@@ -476,7 +476,8 @@ export const createLLMStreamTool = (env: Env) =>
"Returns a streaming response for interactive chat experiences.",
- inputSchema: STREAM_BINDING.inputSchema,
+ // inputSchema: STREAM_BINDING.inputSchema,
+ inputSchema: z.object({}),
execute: async ({ context }) => {
const {
</file context>
Suggested change
| inputSchema: z.object({}), | |
| inputSchema: STREAM_BINDING.inputSchema, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Fix OpenRouter LLM tool bindings to prevent schema validation errors and unblock streaming and generate calls. We now import z from zod and use minimal schemas as placeholders.
Written for commit d20e64d. Summary will update on new commits.