Synthesize Windows temp env vars#135
Merged
Merged
Conversation
LINK.EXE expects Windows-style TMP/TEMP variables when choosing a scratch path for CVTRES. On macOS wibo only inherited TMPDIR, so the linker called GetTempFileNameW with a null path and later crashed the host in WideCharToMultiByte while converting that null pointer. Expose TMP and TEMP from TMPDIR with a /tmp fallback, convert them to Windows paths in the environment APIs, and harden the ANSI/wide conversion shims so invalid guest pointers return ERROR_INVALID_PARAMETER instead of segfaulting wibo. Add regression coverage for the synthesized temp variables and null conversion inputs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LINK.EXE expects Windows-style TMP/TEMP variables when choosing a scratch path for CVTRES. On macOS wibo only inherited TMPDIR, so the linker called GetTempFileNameW with a null path and later crashed the host in WideCharToMultiByte while converting that null pointer.
Expose TMP and TEMP from TMPDIR with a /tmp fallback, convert them to Windows paths in the environment APIs, and harden the ANSI/wide conversion shims so invalid guest pointers return ERROR_INVALID_PARAMETER instead of segfaulting wibo. Add regression coverage for the synthesized temp variables and null conversion inputs.