Skip to content

Fix macOS Homebrew LLVM builds #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
miried wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix macOS Homebrew LLVM builds #138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,7 +322,11 @@ find_package(Python3 COMPONENTS Interpreter REQUIRED)
if (CMAKE_SYSTEM_NAME STREQUAL "Linux")
set(CLANG_ROOT "/usr" CACHE PATH "Path to Clang installation")
elseif (CMAKE_SYSTEM_NAME STREQUAL "Darwin")
set(CLANG_ROOT "/Library/Developer/CommandLineTools/usr/lib" CACHE PATH "Path to Clang installation")
# Prefer libclang from the compiler installation. This keeps Homebrew LLVM
# builds from mixing its clang executable with AppleClang's libclang.
get_filename_component(_CLANG_BIN_DIR "${CMAKE_C_COMPILER}" DIRECTORY)
get_filename_component(_CLANG_COMPILER_ROOT "${_CLANG_BIN_DIR}/.." ABSOLUTE)
set(CLANG_ROOT "${_CLANG_COMPILER_ROOT}" CACHE PATH "Path to Clang installation")
endif()
set(_LLVM_MIN_VER 17)
set(_LLVM_MAX_VER 25)
Expand All @@ -333,7 +337,7 @@ endforeach()
list(APPEND _CLANG_LIB_SUFFIXES llvm/lib lib lib64)
find_library(LIBCLANG_LIBRARY
NAMES libclang clang
HINTS ${CLANG_ROOT}
HINTS ${CLANG_ROOT} "/Library/Developer/CommandLineTools/usr/lib"
PATH_SUFFIXES ${_CLANG_LIB_SUFFIXES}
)
if(NOT LIBCLANG_LIBRARY)
Expand Down
4 changes: 2 additions & 2 deletions CMakePresets.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
"name": "debug-macos",
"displayName": "Debug",
"description": "Debug build (64-bit macOS)",
"inherits": ["ninja-base"],
"inherits": ["ninja-base", "clang-base"],
"binaryDir": "${sourceDir}/build/debug",
"condition": {
"type": "equals",
Expand Down Expand Up @@ -77,7 +77,7 @@
"name": "release-macos",
"displayName": "Release",
"description": "Release build (64-bit macOS)",
"inherits": ["ninja-base"],
"inherits": ["ninja-base", "clang-base"],
"binaryDir": "${sourceDir}/build/release",
"condition": {
"type": "equals",
Expand Down
Loading