core: elevate order fields to core #3300
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martonp
reviewed
Jul 9, 2025
Collaborator
martonp
left a comment
martonp
left a comment
There was a problem hiding this comment.
What's the reasoning behind this? My inclination would be to go in the opposite direction. Instead of bringing things from dexConnection into core, I think it would make more sense to keep things in dexConnection and not have core know about the internal details of dexConnection. The dexConnection type should be turned into an interface that both meshConnection and v1DexConnection (or whatever it's called) implement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a small architectural change that elevates the order maps from
dexConnectiontoCorein preparation for integrating mesh as a source of trades. I think this will save us some headaches going forward.