WIP: feat: DH-22472, DH-22473, DH-22475: Github Actions to build {C++, Python ticking, C#} on {Ubuntu, Windows}#8068
Open
kosak wants to merge 4 commits into
Open
WIP: feat: DH-22472, DH-22473, DH-22475: Github Actions to build {C++, Python ticking, C#} on {Ubuntu, Windows}#8068kosak wants to merge 4 commits into
kosak wants to merge 4 commits into
Conversation
kosak
requested review from
JamesXNelson,
devinrsmith,
jcferretti and
rcaudy
as code owners
Contributor
No docs changes detected for b059114 |
kosak
added
NoDocumentationNeeded
NoReleaseNotesNeeded
kosak
changed the title
Contributor
|
Pull Request titles must follow the Conventional Commits specification. Details: |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds GitHub Actions workflows to build the Deephaven C++ client, the static/ticking Python clients, and the .NET (C#) client on Ubuntu and Windows runners, plus supporting vcpkg configuration and CMake install rules. The C++ build relies on a NuGet-backed vcpkg binary cache to avoid rebuilding dependencies each run.
Changes:
- New workflows:
clients-cpp-python.yml,clients-csharp.yml, and a reusabledhc-version.ymlthat extracts the DHC version fromgradle.properties. - New vcpkg custom triplets (
x64-linux-dynamic-release.cmake,x64-windows-release) and an updatedvcpkg-configuration.jsonbaseline that drops the artifact registry. CMakeLists.txtchange to install vcpkg-built.sofiles alongside the C++ client on Linux toolchain builds.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/clients-cpp-python.yml |
New C++/Python build workflow with vcpkg + NuGet binary caching for Linux and Windows. |
.github/workflows/clients-csharp.yml |
New .NET client build and NuGet packaging workflow on Ubuntu. |
.github/workflows/dhc-version.yml |
Reusable workflow that derives dhc_version via awk on gradle.properties. |
cpp-client/deephaven/CMakeLists.txt |
Adds install rule copying vcpkg shared libraries on non-Windows toolchain builds. |
cpp-client/deephaven/vcpkg-configuration.json |
Updates vcpkg baseline and removes the artifact registry entry. |
cpp-client/deephaven/custom-triplets/x64-linux-dynamic-release.cmake |
New Linux release-only dynamic-link triplet. |
cpp-client/deephaven/custom-triplets/x64-windows-release |
New Windows release-only triplet (missing .cmake extension). |
cpp-client/ARBITRARY_CHANGED_FILE_TO_TRIGGER_REBUILD.txt |
Debug/scratch file used to retrigger CI; should not be merged. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+1
to
+10
| # These settings are inspired by [vcpkg repo]/triplets/x64-windows.cmake | ||
|
|
||
| # These settings are the same: | ||
| set(VCPKG_TARGET_ARCHITECTURE x64) | ||
| set(VCPKG_CRT_LINKAGE dynamic) | ||
| set(VCPKG_LIBRARY_LINKAGE dynamic) | ||
|
|
||
| # This setting is new because we want to build only the 'release' | ||
| # version of the packages, rather the both 'debug' and 'release' | ||
| set(VCPKG_BUILD_TYPE release) |
Contributor
Author
There was a problem hiding this comment.
We would like to use x64-windows-release, but we can't because (kosak thinks) the Google properties like grpc and protobuf aren't honoring it properly.
| include: | ||
| - os: ubuntu-24.04 | ||
| target_triplet: x64-linux-dynamic-release | ||
| - os: windows-2025-vs2026 |
Contributor
Author
There was a problem hiding this comment.
This is a transitionary runner label that github is offering while it transitions to making Visual Studio 2026 standard on all the windows-2025 runners.
Comment on lines
+30
to
+37
| DHC_VERSION=$(awk -F= ' | ||
| /^[^#]/ { props[$1] = $2 } | ||
| END { | ||
| v = props["deephavenMajorVersion"] "." props["deephavenMinorVersion"] | ||
| if (props["deephavenBaseQualifier"] != "") v = v "-" props["deephavenBaseQualifier"] | ||
| print v | ||
| } | ||
| ' gradle.properties) |
Contributor
Author
There was a problem hiding this comment.
I don't care right now unless my reviewers do
kosak
force-pushed
the
kosak_clients-gha
branch
2 times, most recently
from
08eb34d to
f9f4152
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.