Skip to content

feat: DH-22859: Add ForceReadUtility to force read all table data#8135

Open
devinrsmith wants to merge 6 commits into
deephaven:mainfrom
devinrsmith:nightly/column-iterator-consume-all
Open

feat: DH-22859: Add ForceReadUtility to force read all table data#8135
devinrsmith wants to merge 6 commits into
deephaven:mainfrom
devinrsmith:nightly/column-iterator-consume-all

Conversation

@devinrsmith

Copy link
Copy Markdown
Member

No description provided.

@devinrsmith devinrsmith self-assigned this Jun 10, 2026
@github-actions

github-actions Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

No docs changes detected for 2cceeec

* , but callers should prefer to call this method as the primitive implementations will not box, and the iteration
* may be done in a more efficient, chunked manner.
*/
void consumeAll();

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see why this couldn't be on CloseableIterator.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specifically, we care about Table data. There are a lot more implementations of CloseableIterator that are not relevant for the Table data case.

Comment thread engine/api/src/main/java/io/deephaven/engine/table/impl/Utility.java Outdated
Comment thread engine/api/src/main/java/io/deephaven/engine/table/impl/ForceReadUtility.java Outdated
@devinrsmith devinrsmith changed the title WIP: Expose ColumnIterator to Table iterator consumers, add consumeAll feat: DH-22859: Add ForceReadUtility to force read all table data Jun 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants