fix: DH-18770: Chart builder support for ui.table#1356
Open
jnumainville wants to merge 4 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds chart builder support to ui.table by wiring the IrisGrid “create chart” action through the dashboard event hub, so charts can be created against the underlying table model.
Changes:
- Add an
onCreateCharthandler inUITablethat emitsIrisGridEvent.CREATE_CHARTwith chart settings, source panel id, and table metadata. - Pass the underlying
dh.Tablethrough the event payload when the grid model is a table template. - Add Jest tests for the new
onCreateChartwiring and emitted payload behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| plugins/ui/src/js/src/elements/UITable/UITable.tsx | Adds onCreateChart handling and emits a dashboard event for chart creation, including sourcePanelId and table metadata. |
| plugins/ui/src/js/src/elements/UITable/UITable.test.tsx | New tests validating onCreateChart is passed to IrisGrid and that the correct chart-create event payload is emitted. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
ui docs preview (Available for 14 days) |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
ui docs preview (Available for 14 days) |
|
ui docs preview (Available for 14 days) |
jnumainville
requested review from
a team and
vbabich
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ui.tablenow supports chart builder for the underlying table