chore(ui): Clean up children typing to use NodeType#1362
Merged
Conversation
- Replace untyped `*children: Any` parameters with the proper `NodeType` type across deephaven.ui components and HTML elements, expand `NodeType` to include float and tuple, and export `NodeType` from the elements package. - combo_box, list_view, and picker accept Table/PartitionedTable/ItemTableSource children that are handled specially on the JS side. Add an explicit cast to NodeType.
|
ui docs preview (Available for 14 days) |
jnumainville
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
*children: Anyparameters with the properNodeTypetype across deephaven.ui components and HTML elements, expandNodeTypeto include float and tuple, and exportNodeTypefrom the elements package.mapfor children was causing issues with memoization)