Skip to content

fix: Spectrum version bump and pin #2689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jnumainville merged 7 commits into from
Jun 2, 2026
Merged

fix: Spectrum version bump and pin #2689

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f02168e
spectrum bump
jnumainville May 26, 2026
6749b01
fix import
jnumainville May 27, 2026
fe8e7e1
better import
jnumainville May 27, 2026
3079632
type
jnumainville May 27, 2026
edcf638
update all to proper versions
jnumainville May 27, 2026
4f9b198
pin versions
jnumainville May 27, 2026
449636e
correct packages
jnumainville Jun 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3,605 changes: 409 additions & 3,196 deletions package-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion packages/app-utils/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"@deephaven/test-utils": "file:../test-utils"
},
"dependencies": {
"@adobe/react-spectrum": "3.38.0",
"@adobe/react-spectrum": "3.47.0",
"@deephaven/auth-plugins": "file:../auth-plugins",
"@deephaven/chart": "file:../chart",
"@deephaven/components": "file:../components",
Expand Down
2 changes: 1 addition & 1 deletion packages/code-studio/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"directory": "packages/code-studio"
},
"dependencies": {
"@adobe/react-spectrum": "3.38.0",
"@adobe/react-spectrum": "3.47.0",
"@deephaven/app-utils": "file:../app-utils",
"@deephaven/auth-plugins": "file:../auth-plugins",
"@deephaven/chart": "file:../chart",
Expand Down
30 changes: 15 additions & 15 deletions packages/components/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"build:theme": "sass --embed-sources --style=compressed --load-path=../../node_modules ./src/theme:./dist/theme"
},
"dependencies": {
"@adobe/react-spectrum": "3.38.0",
"@adobe/react-spectrum": "3.47.0",
"@deephaven/icons": "file:../icons",
"@deephaven/log": "file:../log",
"@deephaven/react-hooks": "file:../react-hooks",
Expand All @@ -35,20 +35,20 @@
"@fortawesome/react-fontawesome": "^0.2.0",
"@hello-pangea/dnd": "^18.0.1",
"@internationalized/date": "^3.5.5",
"@react-aria/focus": "^3.21.0",
"@react-aria/i18n": "^3.12.11",
"@react-spectrum/label": "^3.16.17",
"@react-spectrum/overlays": "^5.8.0",
"@react-spectrum/theme-default": "^3.5.1",
"@react-spectrum/toast": "^3.0.0-beta.16",
"@react-spectrum/utils": "^3.11.5",
"@react-stately/overlays": "^3.6.18",
"@react-stately/utils": "^3.10.8",
"@react-types/combobox": "3.13.1",
"@react-types/radio": "^3.8.1",
"@react-types/shared": "^3.22.1",
"@react-types/textfield": "^3.9.1",
"@spectrum-icons/ui": "^3.6.18",
"@react-aria/focus": "3.22.0",
"@react-aria/i18n": "3.13.0",
"@react-spectrum/label": "3.17.0",
"@react-spectrum/overlays": "5.10.0",
"@react-spectrum/theme-default": "3.6.0",
"@react-spectrum/toast": "3.2.0",
"@react-spectrum/utils": "3.13.0",
"@react-stately/overlays": "3.7.0",
"@react-stately/utils": "3.12.0",
"@react-types/combobox": "3.15.0",
"@react-types/radio": "3.10.0",
"@react-types/shared": "3.34.0",
"@react-types/textfield": "3.13.0",
"@spectrum-icons/ui": "3.7.0",
Comment on lines +38 to +51

@bmingles bmingles Jun 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What determines which versions you pinned here?

@jnumainville jnumainville Jun 1, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was the packages that were released with "@adobe/react-spectrum": "3.47.0", or at least should have been... two were off but have been fixed.

"bootstrap": "4.6.2",
"classnames": "^2.3.1",
"event-target-shim": "^6.0.2",
Expand Down
9 changes: 7 additions & 2 deletions packages/components/src/dialogs/ActionButtonDialogTrigger.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,14 @@
import { type ReactElement } from 'react';
import type { SpectrumDialogClose } from '@react-types/dialog';
import type { StyleProps } from '@react-types/shared';
import type { IconDefinition } from '@fortawesome/fontawesome-common-types';
import { FontAwesomeIcon } from '@fortawesome/react-fontawesome';
import { ActionButton, DialogTrigger, Icon, Text } from '../spectrum';
import {
ActionButton,
DialogTrigger,
Icon,
Text,
type SpectrumDialogClose,
} from '../spectrum';
import { Tooltip } from '../popper';

export interface ActionButtonDialogTriggerProps extends StyleProps {
Expand Down
1 change: 1 addition & 0 deletions packages/components/src/spectrum/overlays.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ export {
ContextualHelp,
type SpectrumContextualHelpProps as ContextualHelpProps,
Dialog,
type SpectrumDialogClose,
type SpectrumDialogProps as DialogProps,
DialogContainer,
type SpectrumDialogContainerProps as DialogContainerProps,
Expand Down
2 changes: 1 addition & 1 deletion packages/react-hooks/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"build:babel": "babel ./src --out-dir ./dist --extensions \".ts,.tsx,.js,.jsx\" --source-maps --root-mode upward"
},
"dependencies": {
"@adobe/react-spectrum": "3.38.0",
"@adobe/react-spectrum": "3.47.0",
"@deephaven/log": "file:../log",
"@deephaven/utils": "file:../utils",
"lodash.debounce": "^4.0.8",
Expand Down
Loading